Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): comment can cause vIf-related syntax errors #6843

Closed
wants to merge 2 commits into from
Closed

fix(compiler): comment can cause vIf-related syntax errors #6843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdf5cdc
fix(compiler): comment can cause vIf-related syntax errors
Dunqing Oct 10, 2022
e57658e
fix: keep comment
Dunqing Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 11 additions & 3 deletions packages/compiler-core/src/transforms/vIf.ts
View file
Open in desktop
Expand Up @@ -129,18 +129,26 @@ export function processIf(
let i = siblings.indexOf(node)
while (i-- >= -1) {
const sibling = siblings[i]
if (__DEV__ && sibling && sibling.type === NodeTypes.COMMENT) {
if (
__DEV__ &&
!__TEST__ &&
sibling &&
sibling.type === NodeTypes.COMMENT
) {
context.removeNode(sibling)
comments.unshift(sibling)
continue
}

if (
sibling &&
sibling.type === NodeTypes.TEXT &&
!sibling.content.trim().length
((sibling.type === NodeTypes.TEXT && !sibling.content.trim().length) ||
sibling.type === NodeTypes.COMMENT)
) {
context.removeNode(sibling)
if (sibling.type === NodeTypes.COMMENT) {
comments.unshift(sibling)
}
continue
}

Expand Down