-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime): CSSVars can work with Teleport #7344
Open
baiwusanyu-c
wants to merge
45
commits into
vuejs:main
Choose a base branch
from
baiwusanyu-c:bwsy/fix/teleportCSSVars
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
b2d72c7
fix(runtime): cssVars can work with Teleport
baiwusanyu-c 704be6f
fix(runtime): update code for unit test
baiwusanyu-c b8e882d
fix(runtime-core): add unit test
baiwusanyu-c 673940c
fix(runtime-core): update code
baiwusanyu-c b34e64f
fix(runtime-core): update code
baiwusanyu-c f4a605c
fix(compiler-core): Add teleportIds in vnode to achieve correct rende…
baiwusanyu-c 8020386
fix(runtime-core): Update judgment condition code
baiwusanyu-c adc9c58
fix(compiler-core): update unit test and support suspense
baiwusanyu-c 80791fc
fix(compiler-core): added suspense's unit test
baiwusanyu-c ad95ea6
Merge branch 'vuejs:main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 1752fba
Merge branch 'vuejs:main' into bwsy/fix/teleportCSSVars
baiwusanyu-c fe147fc
Merge branch 'vuejs:main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 0dbec82
Merge branch 'vuejs:main' into bwsy/fix/teleportCSSVars
baiwusanyu-c be83253
Merge remote-tracking branch 'origin/main' into bwsy/fix/stringify
baiwusanyu-c 3f2107e
Merge remote-tracking branch 'origin/main' into bwsy/fix/stringify
baiwusanyu-c 0fa8a0a
Merge branch 'vuejs:main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 174aa23
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c a6bed2e
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c be7ef16
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 13c9ab6
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 0b7a33f
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c df43c1e
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 10d4368
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 9bc3b32
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c da36b5c
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 5537755
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 50dbdcb
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 7fbc022
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 21c10f8
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 90361f8
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 2dd703d
Merge remote-tracking branch 'upstream/main' into bwsy/fix/teleportCS…
baiwusanyu-c b7cadc2
Merge branch 'vuejs:main' into bwsy/fix/teleportCSSVars
baiwusanyu-c fa64b07
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 1fc7b21
Merge remote-tracking branch 'origin/main' into bwsy/fix/teleportCSSVars
baiwusanyu-c d081bb4
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c dbec711
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 69b2dcd
updated code
baiwusanyu-c 6e0af13
Merge remote-tracking branch 'upstream/main' into bwsy/fix/teleportCS…
baiwusanyu-c 97aae5f
Merge remote-tracking branch 'origin/main' into bwsy/fix/teleportCSSVars
baiwusanyu-c e3e85d5
Merge remote-tracking branch 'origin/main' into bwsy/fix/teleportCSSVars
baiwusanyu-c a12da2d
Merge remote-tracking branch 'origin/main' into bwsy/fix/teleportCSSVars
baiwusanyu-c 69a4c5f
[autofix.ci] apply automated fixes
autofix-ci[bot] 7067594
chore: updated dts
baiwusanyu-c 5e887ab
Merge remote-tracking branch 'upstream/main' into bwsy/fix/teleportCS…
baiwusanyu-c 4ff76d4
Merge branch 'main' into bwsy/fix/teleportCSSVars
baiwusanyu-c File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
walk vnode tree and observe all teleport node,there may be a extra performance cost
Indeed,we need further consideration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some modifications, but as you said, I also think that doing so will consume a lot of performance.
I think a better approach should be like
suspense
, which handles thecssvars
update onteleport
at the right time during theruntime
process, but that is a big change