Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): Fix cssVar cannot work in teleport #7364

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tinyfind
Copy link

@tinyfind tinyfind commented Dec 17, 2022

close: #7312
close: #7342

@skirtles-code
Copy link
Contributor

Could you maybe explain how your proposed solution compares to the existing PRs for those two issues?

@tinyfind
Copy link
Author

discard use css attribute data-v-owner that cancel updateCssVars limit browser environment only, so #7341 get fixed
modify updateCssVars make cssVar can work in multilevel nesting teleport

// code path here can assume browser environment.

modify setVarsOnVNode add handle for Teleport vnode and use MutationObserver to trigger that #7342 get fixed

@tinyfind
Copy link
Author

tinyfind commented Jan 10, 2023

@sxzz can you help me to review.

@pikax
Copy link
Member

pikax commented Oct 20, 2023

@tinyfind can you provide answers for skirtles questions please?

Could you maybe explain how your proposed solution compares to the existing PRs for those two issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting
3 participants