Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): allow declaring variables after defineProps #7461

Merged
merged 2 commits into from Jan 9, 2023
Merged

fix(compiler-sfc): allow declaring variables after defineProps #7461

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b98c6b8
fix(compiler-sfc): allow declaring variables after defineProps
huang-julien Jan 3, 2023
277f587
test(compiler-sfc): test defineProps in multiple variable declaration
huang-julien Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/compiler-sfc/src/compileScript.ts
View file
Open in desktop
Expand Up @@ -1758,8 +1758,7 @@ function walkDeclaration(
registerBinding(bindings, id, bindingType)
} else {
if (isCallOf(init, DEFINE_PROPS)) {
// skip walking props destructure
return
continue
}
if (id.type === 'ObjectPattern') {
walkObjectPattern(id, bindings, isConst, isDefineCall)
Expand Down