Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): fix :where and :is selector scoped #9735

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

yangxiuxiu1115
Copy link
Contributor

fix: #9707

@@ -144,6 +144,23 @@ describe('SFC scoped CSS', () => {
`)
})

test(':is() and :where()', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work!
I feel we can separate the :where and :is test cases as below:

test(':is()'){
// some case
// move the line 88 case here
}

test(':where()'){
// some case
// move the line 93 case here
}

Copy link

github-actions bot commented Dec 4, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.7 kB 33 kB 29.8 kB
vue.global.prod.js 133 kB 49.8 kB 44.7 kB

Usages

Name Size Gzip Brotli
createApp 48.2 kB 19 kB 17.4 kB
createSSRApp 51.5 kB 20.3 kB 18.5 kB
defineCustomElement 50.6 kB 19.7 kB 18 kB
overall 61.6 kB 23.8 kB 21.7 kB

@yyx990803 yyx990803 merged commit c3e2c55 into vuejs:main Dec 4, 2023
11 checks passed
@yangxiuxiu1115 yangxiuxiu1115 deleted the fix/cssFunction-scoped branch December 4, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scoping does not work as expected when using :is and :where selectors in Vue 3.3.9
3 participants