Skip to content

Commit

Permalink
fix(cypress): update start-server-and-test to 2.0 and use full host url
Browse files Browse the repository at this point in the history
A breaking change was introduced in start-server-and-test 1.5.5
and now :4173 is not equivalent to localhost:4173, which Vite uses by
default, so we have to use the full url in the command.

bahmutov/start-server-and-test#357 (comment)
  • Loading branch information
sodatea committed Feb 28, 2023
1 parent b47c7be commit dd20ac5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 14 deletions.
16 changes: 5 additions & 11 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions template/config/cypress/package.json
@@ -1,10 +1,10 @@
{
"scripts": {
"test:e2e": "start-server-and-test preview :4173 'cypress run --e2e'",
"test:e2e:dev": "start-server-and-test 'vite dev --port 4173' :4173 'cypress open --e2e'"
"test:e2e": "start-server-and-test preview http://localhost:4173 'cypress run --e2e'",
"test:e2e:dev": "start-server-and-test 'vite dev --port 4173' http://localhost:4173 'cypress open --e2e'"
},
"devDependencies": {
"cypress": "^12.6.0",
"start-server-and-test": "^1.15.4"
"start-server-and-test": "^2.0.0"
}
}

0 comments on commit dd20ac5

Please sign in to comment.