Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add
"v-model-argument" and "v-model-custom-modifiers" to the synt…
…ax checked by the `vue/no-unsupported-features` rule. (#1212)
- Loading branch information
Showing
13 changed files
with
288 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /** | ||
| * @author Yosuke Ota | ||
| * See LICENSE file in root directory for full license. | ||
| */ | ||
| 'use strict' | ||
|
|
||
| module.exports = { | ||
| supported: '3.0.0', | ||
| /** @param {RuleContext} context @returns {TemplateListener} */ | ||
| createTemplateBodyVisitor(context) { | ||
| return { | ||
| /** @param {VDirectiveKey & { argument: VExpressionContainer | VIdentifier }} node */ | ||
| "VAttribute[directive=true] > VDirectiveKey[name.name='model'][argument!=null]"( | ||
| node | ||
| ) { | ||
| context.report({ | ||
| node: node.argument, | ||
| messageId: 'forbiddenVModelArgument' | ||
| }) | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /** | ||
| * @author Yosuke Ota | ||
| * See LICENSE file in root directory for full license. | ||
| */ | ||
| 'use strict' | ||
|
|
||
| // ------------------------------------------------------------------------------ | ||
| // Helpers | ||
| // ------------------------------------------------------------------------------ | ||
|
|
||
| const BUILTIN_MODIFIERS = new Set(['lazy', 'number', 'trim']) | ||
|
|
||
| module.exports = { | ||
| supported: '3.0.0', | ||
| /** @param {RuleContext} context @returns {TemplateListener} */ | ||
| createTemplateBodyVisitor(context) { | ||
| return { | ||
| /** @param {VDirectiveKey} node */ | ||
| "VAttribute[directive=true] > VDirectiveKey[name.name='model'][modifiers.length>0]"( | ||
| node | ||
| ) { | ||
| for (const modifier of node.modifiers) { | ||
| if (!BUILTIN_MODIFIERS.has(modifier.name)) { | ||
| context.report({ | ||
| node: modifier, | ||
| messageId: 'forbiddenVModelCustomModifiers' | ||
| }) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
tests/lib/rules/no-unsupported-features/v-model-argument.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /** | ||
| * @author Yosuke Ota | ||
| * See LICENSE file in root directory for full license. | ||
| */ | ||
| 'use strict' | ||
|
|
||
| const RuleTester = require('eslint').RuleTester | ||
| const rule = require('../../../../lib/rules/no-unsupported-features') | ||
| const utils = require('./utils') | ||
|
|
||
| const buildOptions = utils.optionsBuilder('v-model-argument', '^2.6.0') | ||
| const tester = new RuleTester({ | ||
| parser: require.resolve('vue-eslint-parser'), | ||
| parserOptions: { | ||
| ecmaVersion: 2019 | ||
| } | ||
| }) | ||
|
|
||
| tester.run('no-unsupported-features/v-model-argument', rule, { | ||
| valid: [ | ||
| { | ||
| code: ` | ||
| <template> | ||
| <MyInput v-model:foo="foo" /> | ||
| </template>`, | ||
| options: buildOptions({ version: '^3.0.0' }) | ||
| }, | ||
| { | ||
| code: ` | ||
| <template> | ||
| <MyInput v-model="foo" /> | ||
| </template>`, | ||
| options: buildOptions() | ||
| }, | ||
| { | ||
| code: ` | ||
| <template> | ||
| <MyInput v-bind:foo.sync="foo" /> | ||
| </template>`, | ||
| options: buildOptions() | ||
| } | ||
| ], | ||
| invalid: [ | ||
| { | ||
| code: ` | ||
| <template> | ||
| <MyInput v-model:foo="foo" /> | ||
| </template>`, | ||
| options: buildOptions(), | ||
| errors: [ | ||
| { | ||
| message: | ||
| 'Argument on `v-model` is not supported until Vue.js "3.0.0".', | ||
| line: 3 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }) |
Oops, something went wrong.