Fix: no-boolean-default with 'default-false' on boolean props with un…

…set default (#821)
vuejs · Feb 18, 2019 · 06c11f2 · 06c11f2
1 parent 1447bab
commit 06c11f2
Show file tree

Hide file tree

Showing 2 changed files with 154 additions and 4 deletions.
diff --git a/lib/rules/no-boolean-default.js b/lib/rules/no-boolean-default.js
@@ -78,10 +78,13 @@ module.exports = {
             break
 
           case 'default-false':
-            if (defaultNode.value.value !== false) {
+            if (
+              defaultNode &&
+              defaultNode.value.value !== false
+            ) {
               context.report({
                 node: defaultNode,
-                message: 'Boolean prop should be defaulted to false.'
+                message: 'Boolean prop should only be defaulted to false.'
               })
             }
             break

diff --git a/tests/lib/rules/no-boolean-default.js b/tests/lib/rules/no-boolean-default.js
@@ -35,6 +35,53 @@ ruleTester.run('no-boolean-default', rule, {
         }
       `
     },
+    {
+      filename: 'test.vue',
+      code: `
+        export default {
+          props: {
+            enabled: Boolean
+          }
+        }
+      `,
+      options: ['no-default']
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        export default {
+          props: {
+            enabled: Boolean
+          }
+        }
+      `,
+      options: ['default-false']
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        const props = {};
+        export default {
+          props: {
+            ...props,
+            enabled: Boolean
+          }
+        }
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        const props = {};
+        export default {
+          props: {
+            ...props,
+            enabled: Boolean
+          }
+        }
+      `,
+      options: ['no-default']
+    },
     {
       filename: 'test.vue',
       code: `
@@ -45,6 +92,21 @@ ruleTester.run('no-boolean-default', rule, {
             enabled: Boolean
           }
         }
+      `,
+      options: ['default-false']
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        const data = {};
+        export default {
+          props: {
+            enabled: {
+              type: Boolean,
+              ...data
+            }
+          }
+        }
       `
     },
     {
@@ -62,6 +124,21 @@ ruleTester.run('no-boolean-default', rule, {
       `,
       options: ['no-default']
     },
+    {
+      filename: 'test.vue',
+      code: `
+        const data = {};
+        export default {
+          props: {
+            enabled: {
+              type: Boolean,
+              ...data
+            }
+          }
+        }
+      `,
+      options: ['default-false']
+    },
     {
       filename: 'test.vue',
       code: `
@@ -89,6 +166,30 @@ ruleTester.run('no-boolean-default', rule, {
         }
       `
     },
+    {
+      filename: 'test.vue',
+      code: `
+        const data = {};
+        export default {
+          props: {
+            enabled: data
+          }
+        }
+      `,
+      options: ['no-default']
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        const data = {};
+        export default {
+          props: {
+            enabled: data
+          }
+        }
+      `,
+      options: ['default-false']
+    },
     {
       filename: 'test.vue',
       code: `
@@ -101,6 +202,34 @@ ruleTester.run('no-boolean-default', rule, {
           }
         }
       `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        const data = {};
+        export default {
+          props: {
+            enabled: {
+              ...data
+            }
+          }
+        }
+      `,
+      options: ['no-default']
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        const data = {};
+        export default {
+          props: {
+            enabled: {
+              ...data
+            }
+          }
+        }
+      `,
+      options: ['default-false']
     }
   ],
 
@@ -119,7 +248,7 @@ ruleTester.run('no-boolean-default', rule, {
       `,
       options: ['default-false'],
       errors: [{
-        message: 'Boolean prop should be defaulted to false.',
+        message: 'Boolean prop should only be defaulted to false.',
         line: 6
       }]
     },
@@ -137,7 +266,7 @@ ruleTester.run('no-boolean-default', rule, {
       `,
       options: ['default-false'],
       errors: [{
-        message: 'Boolean prop should be defaulted to false.',
+        message: 'Boolean prop should only be defaulted to false.',
         line: 6
       }]
     },
@@ -158,6 +287,24 @@ ruleTester.run('no-boolean-default', rule, {
         message: 'Boolean prop should not set a default (Vue defaults it to false).',
         line: 6
       }]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        export default {
+          props: {
+            enabled: {
+              type: Boolean,
+              default: true,
+            }
+          }
+        }
+      `,
+      options: ['no-default'],
+      errors: [{
+        message: 'Boolean prop should not set a default (Vue defaults it to false).',
+        line: 6
+      }]
     }
   ]
 })