Fix false positives for import binding in vue/valid-define-emits an…

…d `vue/valid-define-props` rules (#1736) * Fix false positives for import binding in `vue/valid-define-emits` and `vue/valid-define-props` rules * Apply suggestions from code review Co-authored-by: Flo Edelmann <florian-edelmann@online.de> * fix Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
vuejs · Dec 3, 2021 · 09d7bed · 09d7bed
1 parent 8a0b2c8
commit 09d7bed
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 0 deletions.
diff --git a/lib/rules/valid-define-emits.js b/lib/rules/valid-define-emits.js
@@ -79,6 +79,7 @@ module.exports = {
                   variable.defs.length &&
                   variable.defs.every(
                     (def) =>
+                      def.type !== 'ImportBinding' &&
                       utils.inRange(scriptSetup.range, def.name) &&
                       !utils.inRange(defineEmits.range, def.name)
                   )

diff --git a/lib/rules/valid-define-props.js b/lib/rules/valid-define-props.js
@@ -80,6 +80,7 @@ module.exports = {
                   variable.defs.length &&
                   variable.defs.every(
                     (def) =>
+                      def.type !== 'ImportBinding' &&
                       utils.inRange(scriptSetup.range, def.name) &&
                       !utils.inRange(defineProps.range, def.name)
                   )

diff --git a/tests/lib/rules/valid-define-emits.js b/tests/lib/rules/valid-define-emits.js
@@ -117,6 +117,16 @@ tester.run('valid-define-emits', rule, {
       });
       </script>
       `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup>
+      import { propsDef, emitsDef } from './defs';
+
+      defineProps(propsDef);
+      defineEmits(emitsDef);
+      </script>`
     }
   ],
   invalid: [

diff --git a/tests/lib/rules/valid-define-props.js b/tests/lib/rules/valid-define-props.js
@@ -120,6 +120,16 @@ tester.run('valid-define-props', rule, {
       });
       </script>
       `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup>
+      import { propsDef, emitsDef } from './defs';
+
+      defineProps(propsDef);
+      defineEmits(emitsDef);
+      </script>`
     }
   ],
   invalid: [