Fixed an issue that caused an error when extra commas were included i…

…n `require-prop-type-constructor` (#963)
vuejs · Dec 26, 2019 · 2418da7 · 2418da7
1 parent b412783
commit 2418da7
Show file tree

Hide file tree

Showing 3 changed files with 74 additions and 1 deletion.
diff --git a/lib/rules/require-prop-type-constructor.js b/lib/rules/require-prop-type-constructor.js
@@ -58,7 +58,7 @@ module.exports = {
         })
       } else if (node.type === 'ArrayExpression') {
         node.elements
-          .filter(prop => isForbiddenType(prop))
+          .filter(prop => prop && isForbiddenType(prop))
           .forEach(prop => context.report({
             node: prop,
             message,

diff --git a/lib/utils/index.js b/lib/utils/index.js
@@ -453,6 +453,7 @@ module.exports = {
         })
     } else {
       props = propsNode.value.elements
+        .filter(prop => prop)
         .map(prop => {
           const key = prop.type === 'Literal' && typeof prop.value === 'string' ? prop : null
           return { key, value: null, node: prop, propName: key != null ? prop.value : null }

diff --git a/tests/lib/rules/require-prop-type-constructor.js b/tests/lib/rules/require-prop-type-constructor.js
@@ -44,6 +44,56 @@ ruleTester.run('require-prop-type-constructor', rule, {
           }
         }
       `
+    },
+    {
+      filename: 'ExtraCommas.vue',
+      code: `
+        export default {
+          props: {
+            name: [String,,]
+          }
+        }
+      `
+    },
+    {
+      filename: 'ExtraCommas.vue',
+      code: `
+        export default {
+          props: {
+            name: {
+              type: [String,,]
+            }
+          }
+        }
+      `
+    },
+    {
+      filename: 'ExtraCommas.vue',
+      code: `
+        export default {
+          props: {
+            name: [String,,Number]
+          }
+        }
+      `
+    },
+    {
+      filename: 'ExtraCommas.vue',
+      code: `
+        export default {
+          props: {
+            name: [,,Number]
+          }
+        }
+      `
+    },
+    {
+      filename: 'ExtraCommas.vue',
+      code: `
+        export default {
+          props: ['name',,,]
+        }
+      `
     }
   ],
 
@@ -165,6 +215,28 @@ ruleTester.run('require-prop-type-constructor', rule, {
         line: 5
       }],
       parser: require.resolve('@typescript-eslint/parser')
+    },
+    {
+      filename: 'ExtraCommas.vue',
+      code: `
+      export default {
+        props: {
+          name: ['String',,]
+        }
+      }
+      `,
+      output: `
+      export default {
+        props: {
+          name: [String,,]
+        }
+      }
+      `,
+      errors: [{
+        message: 'The "name" property should be a constructor.',
+        line: 4
+      }],
+      parser: require.resolve('@typescript-eslint/parser')
     }
   ]
 })