Fix multiple reporting of same warnings in `vue/no-unregistered-compo…

…nent` (#1382) * fix multiple reporting of unregistered components * add tests * fix linter error
vuejs · Dec 18, 2020 · 2567f16 · 2567f16
1 parent b617e71
commit 2567f16
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/lib/rules/no-unregistered-components.js b/lib/rules/no-unregistered-components.js
@@ -126,7 +126,7 @@ module.exports = {
           usedComponentNodes.push({ node, name: node.value.value })
         },
         /** @param {VElement} node */
-        "VElement[name='template']:exit"() {
+        "VElement[name='template'][parent.type='VDocumentFragment']:exit"() {
           // All registered components, transformed to kebab-case
           const registeredComponentNames = registeredComponents.map(
             ({ name }) => casing.kebabCase(name)

diff --git a/tests/lib/rules/no-unregistered-components.js b/tests/lib/rules/no-unregistered-components.js
@@ -458,6 +458,25 @@ tester.run('no-unregistered-components', rule, {
         }
         </script>
       `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <CustomComponentWithNamedSlots>
+            <template #slotA>
+              <div>Text</div>
+            </template>
+          </CustomComponentWithNamedSlots>
+        </template>
+        <script>
+        export default {
+          components: {
+            CustomComponentWithNamedSlots
+          }
+        }
+        </script>
+      `
     }
   ],
   invalid: [
@@ -668,6 +687,25 @@ tester.run('no-unregistered-components', rule, {
           line: 3
         }
       ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <CustomComponentWithNamedSlots>
+            <template #slotA>
+              <div>Text</div>
+            </template>
+          </CustomComponentWithNamedSlots>
+        </template>
+      `,
+      errors: [
+        {
+          message:
+            'The "CustomComponentWithNamedSlots" component has been used but not registered.',
+          line: 3
+        }
+      ]
     }
   ]
 })