Fix false positives for arrow return in vue/valid-next-tick rule (#…

…1686)
vuejs · Oct 29, 2021 · 6234455 · 6234455
1 parent 3b5b127
commit 6234455
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/lib/rules/valid-next-tick.js b/lib/rules/valid-next-tick.js
@@ -76,6 +76,13 @@ function isAwaitedPromise(callExpression) {
     // cases like `return nextTick()`
     return true
   }
+  if (
+    callExpression.parent.type === 'ArrowFunctionExpression' &&
+    callExpression.parent.body === callExpression
+  ) {
+    // cases like `() => nextTick()`
+    return true
+  }
 
   if (
     callExpression.parent.type === 'MemberExpression' &&

diff --git a/tests/lib/rules/valid-next-tick.js b/tests/lib/rules/valid-next-tick.js
@@ -113,6 +113,22 @@ tester.run('valid-next-tick', rule, {
           return this.$nextTick();
         }
       }</script>`
+    },
+
+    {
+      filename: 'test.vue',
+      code: `<script>;
+      export default {
+        methods: {
+          fn1 () {
+            return this.$nextTick()
+          },
+          fn2 () {
+            return this.$nextTick()
+              .then(() => this.$nextTick())
+          },
+        }
+      }</script>`
     }
   ],
   invalid: [