Skip to content

Commit

Permalink
Chore: Update packages to support ESlint v6 (#979)
Browse files Browse the repository at this point in the history
* Update packages to support ESlint 6

* Update Node.js requirement to 8.10 and above

* Remove Eslint@5 compatibility check from CircleCI
  • Loading branch information
michalsnik committed Nov 6, 2019
1 parent edf43ff commit 6d48d11
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 38 deletions.
30 changes: 0 additions & 30 deletions .circleci/config.yml
Expand Up @@ -5,7 +5,6 @@ workflows:
- node-v8
- node-v10
- node-v12
- node-v12-minimal

version: 2
jobs:
Expand Down Expand Up @@ -43,32 +42,3 @@ jobs:
<<: *node-base
docker:
- image: node:12

node-v12-minimal:
docker:
- image: node:12
steps:
- run:
name: Versions
command: npm version
- checkout
- restore_cache:
keys:
- v2-npm-lock-{{ .Branch }}-{{ .Environment.CIRCLE_JOB }}-{{ checksum "package.json" }}
- run:
name: Install dependencies
command: npm install
- save_cache:
key: v2-npm-lock-{{ .Branch }}-{{ .Environment.CIRCLE_JOB }}-{{ checksum "package.json" }}
paths:
- node_modules
- run:
name: Install eslint 5
command: |
# We need to execute this command twice because of npm's bug.
# See also: https://npm.community/t/error-node-modules-staging-eslint-e7cf6846-node-modules-eslint
npm install eslint@5.0.0 acorn@6.0.7 --no-save
npm install eslint@5.0.0 acorn@6.0.7 --no-save
- run:
name: Test
command: npm test
4 changes: 2 additions & 2 deletions docs/user-guide/README.md
Expand Up @@ -18,8 +18,8 @@ yarn add -D eslint eslint-plugin-vue
```

::: tip Requirements
- ESLint v5.0.0 or later
- Node.js v6.5.0 or later
- ESLint v6.0.0 and above
- Node.js v8.10.0 and above
:::

## :book: Usage
Expand Down
8 changes: 4 additions & 4 deletions package.json 100755 → 100644
Expand Up @@ -40,7 +40,7 @@
"url": "https://github.com/vuejs/eslint-plugin-vue/issues"
},
"engines": {
"node": ">=6.5"
"node": ">=8.10"
},
"peerDependencies": {
"eslint": "^5.0.0 || ^6.0.0"
Expand All @@ -50,15 +50,15 @@
},
"devDependencies": {
"@types/node": "^4.2.16",
"@typescript-eslint/parser": "^1.11.0",
"acorn": "^7.0.0",
"@typescript-eslint/parser": "^2.6.1",
"acorn": "^7.1.0",
"babel-eslint": "^10.0.2",
"chai": "^4.1.0",
"eslint": "^6.0.0",
"eslint-plugin-eslint-plugin": "^2.0.1",
"eslint-plugin-vue-libs": "^4.0.0",
"eslint-plugin-vue": "file:.",
"eslint4b": "^5.1.0",
"eslint4b": "^6.6.0",
"lodash": "^4.17.4",
"mocha": "^5.2.0",
"nyc": "^12.0.2",
Expand Down
4 changes: 2 additions & 2 deletions tests/integrations/eslint-plugin-import/package.json
Expand Up @@ -8,8 +8,8 @@
"author": "Toru Nagashima (https://github.com/mysticatea)",
"license": "MIT",
"dependencies": {
"eslint": "~3.19.0",
"eslint-plugin-import": "~2.3.0",
"eslint": "~6.0.0",
"eslint-plugin-import": "~2.18.2",
"eslint-plugin-vue": "file:../../.."
}
}

0 comments on commit 6d48d11

Please sign in to comment.