Fix false positives for quoted 'emits' in vue/require-explicit-emits …

…rule (#1420)
vuejs · Jan 22, 2021 · bbbb6ca · bbbb6ca
1 parent 2d290b2
commit bbbb6ca
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 8 deletions.
diff --git a/lib/utils/index.js b/lib/utils/index.js
@@ -544,8 +544,7 @@ module.exports = {
       (p) => {
         return (
           p.type === 'Property' &&
-          p.key.type === 'Identifier' &&
-          p.key.name === 'components' &&
+          getStaticPropertyName(p) === 'components' &&
           p.value.type === 'ObjectExpression'
         )
       }
@@ -677,8 +676,7 @@ module.exports = {
       (p) => {
         return (
           p.type === 'Property' &&
-          p.key.type === 'Identifier' &&
-          p.key.name === 'props' &&
+          getStaticPropertyName(p) === 'props' &&
           (p.value.type === 'ObjectExpression' ||
             p.value.type === 'ArrayExpression')
         )
@@ -748,8 +746,7 @@ module.exports = {
       (p) => {
         return (
           p.type === 'Property' &&
-          p.key.type === 'Identifier' &&
-          p.key.name === 'emits' &&
+          getStaticPropertyName(p) === 'emits' &&
           (p.value.type === 'ObjectExpression' ||
             p.value.type === 'ArrayExpression')
         )
@@ -819,8 +816,7 @@ module.exports = {
       (p) => {
         return (
           p.type === 'Property' &&
-          p.key.type === 'Identifier' &&
-          p.key.name === 'computed' &&
+          getStaticPropertyName(p) === 'computed' &&
           p.value.type === 'ObjectExpression'
         )
       }

diff --git a/tests/lib/rules/require-explicit-emits.js b/tests/lib/rules/require-explicit-emits.js
@@ -140,6 +140,20 @@ tester.run('require-explicit-emits', rule, {
       </script>
       `
     },
+    // quoted
+    {
+      filename: 'test.vue',
+      code: `
+      <template>
+        <div @click="$emit('welcome')"/>
+      </template>
+      <script>
+      export default {
+        'emits': ['welcome']
+      }
+      </script>
+      `
+    },
     // unknown
     {
       filename: 'test.vue',

diff --git a/tests/lib/rules/return-in-computed-property.js b/tests/lib/rules/return-in-computed-property.js
@@ -394,6 +394,23 @@ ruleTester.run('return-in-computed-property', rule, {
           line: 5
         }
       ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      export default {
+        'computed': {
+          foo() {
+          }
+        }
+      }`,
+      parserOptions,
+      errors: [
+        {
+          message: 'Expected to return a value in "foo" computed property.',
+          line: 4
+        }
+      ]
     }
   ]
 })