Skip to content

Commit

Permalink
⭐️New: Add vue/component-tags-order rule (#763)
Browse files Browse the repository at this point in the history
* ⭐️New: Add `vue/component-tags-order` rule

* Upgrade vue-eslint-parser@^7.0.0

* Use parserServices.getDocumentFragment
  • Loading branch information
ota-meshi committed Dec 26, 2019
1 parent 8d7cadf commit c360057
Show file tree
Hide file tree
Showing 5 changed files with 408 additions and 0 deletions.
1 change: 1 addition & 0 deletions docs/rules/README.md
Expand Up @@ -146,6 +146,7 @@ For example:
| [vue/camelcase](./camelcase.md) | enforce camelcase naming convention | |
| [vue/comma-dangle](./comma-dangle.md) | require or disallow trailing commas | :wrench: |
| [vue/component-name-in-template-casing](./component-name-in-template-casing.md) | enforce specific casing for the component naming style in template | :wrench: |
| [vue/component-tags-order](./component-tags-order.md) | enforce order of component top-level elements | |
| [vue/dot-location](./dot-location.md) | enforce consistent newlines before and after dots | :wrench: |
| [vue/eqeqeq](./eqeqeq.md) | require the use of `===` and `!==` | :wrench: |
| [vue/key-spacing](./key-spacing.md) | enforce consistent spacing between keys and values in object literal properties | :wrench: |
Expand Down
96 changes: 96 additions & 0 deletions docs/rules/component-tags-order.md
@@ -0,0 +1,96 @@
---
pageClass: rule-details
sidebarDepth: 0
title: vue/component-tags-order
description: enforce order of component top-level elements
---
# vue/component-tags-order
> enforce order of component top-level elements
## :book: Rule Details

This rule warns about the order of the `<script>`, `<template>` & `<style>` tags.

## :wrench: Options

```json
{
"vue/component-tags-order": ["error", {
"order": ["script", "template", "style"]
}]
}
```

- `order` (`string[]`) ... The order of top-level element names. default `["script", "template", "style"]`.

### `{ "order": ["script", "template", "style"] }` (default)

<eslint-code-block :rules="{'vue/component-tags-order': ['error']}">

```vue
<!-- ✓ GOOD -->
<script>/* ... */</script>
<template>...</template>
<style>/* ... */</style>
```

</eslint-code-block>

<eslint-code-block :rules="{'vue/component-tags-order': ['error']}">

```vue
<!-- ✗ BAD -->
<style>/* ... */</style>
<script>/* ... */</script>
<template>...</template>
```

</eslint-code-block>

### `{ "order": ["template", "script", "style"] }`

<eslint-code-block :rules="{'vue/component-tags-order': ['error', { 'order': ['template', 'script', 'style'] }]}">

```vue
<!-- ✓ GOOD -->
<template>...</template>
<script>/* ... */</script>
<style>/* ... */</style>
```

</eslint-code-block>

### `{ "order": ["docs", "template", "script", "style"] }`

<eslint-code-block :rules="{'vue/component-tags-order': ['error', { 'order': ['docs', 'template', 'script', 'style'] }]}">

```vue
<!-- ✓ GOOD -->
<docs> documents </docs>
<template>...</template>
<script>/* ... */</script>
<style>/* ... */</style>
```

</eslint-code-block>

<eslint-code-block :rules="{'vue/component-tags-order': ['error', { 'order': ['docs', 'template', 'script', 'style'] }]}">

```vue
<!-- ✗ BAD -->
<template>...</template>
<script>/* ... */</script>
<docs> documents </docs>
<style>/* ... */</style>
```

</eslint-code-block>

## :books: Further reading

- [Style guide - Single-file component top-level element order](https://vuejs.org/v2/style-guide/#Single-file-component-top-level-element-order-recommended)

## :mag: Implementation

- [Rule source](https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/component-tags-order.js)
- [Test source](https://github.com/vuejs/eslint-plugin-vue/blob/master/tests/lib/rules/component-tags-order.js)
1 change: 1 addition & 0 deletions lib/index.js
Expand Up @@ -17,6 +17,7 @@ module.exports = {
'comma-dangle': require('./rules/comma-dangle'),
'comment-directive': require('./rules/comment-directive'),
'component-name-in-template-casing': require('./rules/component-name-in-template-casing'),
'component-tags-order': require('./rules/component-tags-order'),
'dot-location': require('./rules/dot-location'),
'eqeqeq': require('./rules/eqeqeq'),
'html-closing-bracket-newline': require('./rules/html-closing-bracket-newline'),
Expand Down
93 changes: 93 additions & 0 deletions lib/rules/component-tags-order.js
@@ -0,0 +1,93 @@
/**
* @author Yosuke Ota
* issue https://github.com/vuejs/eslint-plugin-vue/issues/140
*/
'use strict'

// ------------------------------------------------------------------------------
// Requirements
// ------------------------------------------------------------------------------

const utils = require('../utils')

const DEFAULT_ORDER = Object.freeze(['script', 'template', 'style'])

// ------------------------------------------------------------------------------
// Rule Definition
// ------------------------------------------------------------------------------

module.exports = {
meta: {
type: 'suggestion',
docs: {
description: 'enforce order of component top-level elements',
category: undefined,
url: 'https://eslint.vuejs.org/rules/component-tags-order.html'
},
fixable: null,
schema: {
type: 'array',
properties: {
order: {
type: 'array'
}
}
},
messages: {
unexpected: 'The <{{name}}> should be above the <{{firstUnorderedName}}> on line {{line}}.'
}
},
create (context) {
const order = (context.options[0] && context.options[0].order) || DEFAULT_ORDER
const documentFragment = context.parserServices.getDocumentFragment && context.parserServices.getDocumentFragment()

function getTopLevelHTMLElements () {
if (documentFragment) {
return documentFragment.children
}
return []
}

function report (element, firstUnorderedElement) {
context.report({
node: element,
loc: element.loc,
messageId: 'unexpected',
data: {
name: element.name,
firstUnorderedName: firstUnorderedElement.name,
line: firstUnorderedElement.loc.start.line
}
})
}

return utils.defineTemplateBodyVisitor(
context,
{},
{
Program (node) {
if (utils.hasInvalidEOF(node)) {
return
}
const elements = getTopLevelHTMLElements()

elements.forEach((element, index) => {
const expectedIndex = order.indexOf(element.name)
if (expectedIndex < 0) {
return
}
const firstUnordered = elements
.slice(0, index)
.filter(e => expectedIndex < order.indexOf(e.name))
.sort(
(e1, e2) => order.indexOf(e1.name) - order.indexOf(e2.name)
)[0]
if (firstUnordered) {
report(element, firstUnordered)
}
})
}
}
)
}
}

0 comments on commit c360057

Please sign in to comment.