Fix crash in component-api-style rule (#1721)

vuejs · Nov 18, 2021 · c931ae6 · c931ae6
1 parent 20eaee7
commit c931ae6
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 7 deletions.
diff --git a/lib/rules/component-api-style.js b/lib/rules/component-api-style.js
@@ -274,19 +274,18 @@ module.exports = {
             if (!name) {
               continue
             }
-            const propAllowed = apis.some(
-              (api) => api.allow && api.options.has(name)
-            )
-            if (!propAllowed) {
+            const disallowApi =
+              !apis.some((api) => api.allow && api.options.has(name)) &&
+              apis.find((api) => !api.allow && api.options.has(name))
+
+            if (disallowApi) {
               context.report({
                 node: prop.key,
                 messageId: isPreferScriptSetup(allows)
                   ? 'disallowComponentOptionPreferScriptSetup'
                   : 'disallowComponentOption',
                 data: {
-                  disallowedApi: apis.filter(
-                    (api) => !api.allow && api.options.has(name)
-                  )[0].apiName,
+                  disallowedApi: disallowApi.apiName,
                   optionPhrase: buildOptionPhrase(name),
                   allowedApis: buildAllowedPhrase(allows)
                 }

diff --git a/tests/lib/rules/component-api-style.js b/tests/lib/rules/component-api-style.js
@@ -181,6 +181,35 @@ tester.run('component-api-style', rule, {
       }
       </script>
       `
+    },
+    {
+      // https://github.com/vuejs/eslint-plugin-vue/issues/1720
+      filename: 'test.vue',
+      options: [['composition']],
+      code: `
+      <template>
+        <div id="app">
+          <header>
+            <Navigation />
+          </header>
+          <main class="container-fluid mb-4" role="main">
+            <RouterView />
+          </main>
+        </div>
+      </template>
+
+      <script lang="ts">
+      import { defineComponent } from '@vue/composition-api'
+
+      import Navigation from '@/components/app/nav/Navigation.vue'
+
+      export default defineComponent({
+        name: 'App',
+        components: {
+          Navigation,
+        },
+      })
+      </script>`
     }
   ],
   invalid: [