Update: allow more cases in require-direct-export (#1450)

(fixes #907)
vuejs · Mar 22, 2021 · ff8cfaa · ff8cfaa
1 parent 43a01cf
commit ff8cfaa
Show file tree

Hide file tree

Showing 2 changed files with 67 additions and 0 deletions.
diff --git a/lib/rules/require-direct-export.js b/lib/rules/require-direct-export.js
@@ -55,6 +55,25 @@ module.exports = {
           // OK
           return
         }
+        if (node.type === 'CallExpression') {
+          const {
+            callee,
+            arguments: [firstArg]
+          } = node
+          if (firstArg && firstArg.type === 'ObjectExpression') {
+            if (
+              (callee.type === 'Identifier' &&
+                callee.name === 'defineComponent') ||
+              (callee.type === 'MemberExpression' &&
+                callee.object.type === 'Identifier' &&
+                callee.object.name === 'Vue' &&
+                callee.property.type === 'Identifier' &&
+                callee.property.name === 'extend')
+            ) {
+              return
+            }
+          }
+        }
         if (!disallowFunctional) {
           if (node.type === 'ArrowFunctionExpression') {
             if (node.body.type !== 'BlockStatement') {

diff --git a/tests/lib/rules/require-direct-export.js b/tests/lib/rules/require-direct-export.js
@@ -74,6 +74,20 @@ ruleTester.run('require-direct-export', rule, {
       import { h } from 'vue'
       export default props => h('div', props.msg)
       `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      import Vue from 'vue'
+      export default Vue.extend({})
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      import { defineComponent } from 'vue'
+      export default defineComponent({})
+      `
     }
   ],
 
@@ -224,6 +238,40 @@ ruleTester.run('require-direct-export', rule, {
       `,
       options: [{ disallowFunctionalComponentFunction: true }],
       errors: ['Expected the component literal to be directly exported.']
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      import Vue from 'vue'
+      export default Vue.extend()
+      `,
+      errors: ['Expected the component literal to be directly exported.']
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      import Vue from 'vue'
+      const A = {}
+      export default Vue.extend(A)
+      `,
+      errors: ['Expected the component literal to be directly exported.']
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      import { defineComponent } from 'vue'
+      export default defineComponent()
+      `,
+      errors: ['Expected the component literal to be directly exported.']
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      import { defineComponent } from 'vue'
+      const A = {}
+      export default defineComponent(A)
+      `,
+      errors: ['Expected the component literal to be directly exported.']
     }
   ]
 })