Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue/no-useless-concat rule #1171

Merged
merged 1 commit into from May 30, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/rules/README.md
Expand Up @@ -302,6 +302,7 @@ For example:
| [vue/no-unregistered-components](./no-unregistered-components.md) | disallow using components that are not registered inside templates | |
| [vue/no-unsupported-features](./no-unsupported-features.md) | disallow unsupported Vue.js syntax on the specified version | :wrench: |
| [vue/no-unused-properties](./no-unused-properties.md) | disallow unused properties | |
| [vue/no-useless-concat](./no-useless-concat.md) | disallow unnecessary concatenation of literals or template literals | |
| [vue/object-curly-spacing](./object-curly-spacing.md) | enforce consistent spacing inside braces | :wrench: |
| [vue/padding-line-between-blocks](./padding-line-between-blocks.md) | require or disallow padding lines between blocks | :wrench: |
| [vue/prefer-template](./prefer-template.md) | require template literals instead of string concatenation | :wrench: |
Expand Down
21 changes: 21 additions & 0 deletions docs/rules/no-useless-concat.md
@@ -0,0 +1,21 @@
---
pageClass: rule-details
sidebarDepth: 0
title: vue/no-useless-concat
description: disallow unnecessary concatenation of literals or template literals
---
# vue/no-useless-concat
> disallow unnecessary concatenation of literals or template literals

This rule is the same rule as core [no-useless-concat] rule but it applies to the expressions in `<template>`.

## :books: Further reading

- [no-useless-concat]

[no-useless-concat]: https://eslint.org/docs/rules/no-useless-concat

## :mag: Implementation

- [Rule source](https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/no-useless-concat.js)
- [Test source](https://github.com/vuejs/eslint-plugin-vue/blob/master/tests/lib/rules/no-useless-concat.js)
1 change: 1 addition & 0 deletions lib/index.js
Expand Up @@ -91,6 +91,7 @@ module.exports = {
'no-unused-properties': require('./rules/no-unused-properties'),
'no-unused-vars': require('./rules/no-unused-vars'),
'no-use-v-if-with-v-for': require('./rules/no-use-v-if-with-v-for'),
'no-useless-concat': require('./rules/no-useless-concat'),
'no-v-html': require('./rules/no-v-html'),
'no-v-model-argument': require('./rules/no-v-model-argument'),
'no-watch-after-await': require('./rules/no-watch-after-await'),
Expand Down
9 changes: 9 additions & 0 deletions lib/rules/no-useless-concat.js
@@ -0,0 +1,9 @@
/**
* @author Yosuke Ota
*/
'use strict'

const { wrapCoreRule } = require('../utils')

// eslint-disable-next-line no-invalid-meta, no-invalid-meta-docs-categories
module.exports = wrapCoreRule(require('eslint/lib/rules/no-useless-concat'))
30 changes: 30 additions & 0 deletions tests/lib/rules/no-useless-concat.js
@@ -0,0 +1,30 @@
/**
* @author Yosuke Ota
*/
'use strict'

const RuleTester = require('eslint').RuleTester
const rule = require('../../../lib/rules/no-useless-concat')

const tester = new RuleTester({
parser: require.resolve('vue-eslint-parser'),
parserOptions: { ecmaVersion: 2015 }
})

tester.run('no-useless-concat', rule, {
valid: [
`<template><div :attr="'foo-bar'" /></template>`,
'<template><div attr="foo-bar" /></template>',
`<template><div :[\`foo-bar\`]="a" /></template>`
],
invalid: [
{
code: `<template><div :attr="'foo'+'bar'" /></template>`,
errors: ['Unexpected string concatenation of literals.']
},
{
code: `<template><div :[\`foo\`+\`bar\`]="a" /></template>`,
errors: ['Unexpected string concatenation of literals.']
}
]
})