Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include Vue3 script setup compiler macro globals #1682

Closed
wants to merge 2 commits into from

Conversation

foxxyz
Copy link
Contributor

@foxxyz foxxyz commented Oct 28, 2021

  • Adds ability to add globals overrides for specific configurations.
  • Adds Vue3 compiler macros to the vue3-essential config so users do not need to add them manually.

Please let me know if you want to me add/change anything! This approach seems more straightforward than what is mentioned in #1662, but maybe there is some downside I don't know about.

Thanks for making this great plugin!

Closes #1662.

@ota-meshi
Copy link
Member

Thank you for this PR.
But I don't want to include globals in the configuration provided by this plugin. It means that you can use defineProps from .js files and .vue other than <script setup>. But they cannot be used. Users must accept the risk and make a choice.

@ota-meshi ota-meshi closed this Oct 28, 2021
@foxxyz
Copy link
Contributor Author

foxxyz commented Oct 28, 2021

Thank you for the feedback, it makes sense. I've tried a different approach in #1685.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: setup compiler macros environment
2 participants