Improve auto-fix for vue/define-macros-order rule
#1863
Conversation
| @@ -232,13 +232,12 @@ function create(context) { | |||
| const targetComment = sourceCode.getTokenAfter(beforeTargetToken, { | |||
| includeComments: true | |||
| }) | |||
| const textSpace = getTextBetweenTokens(beforeTargetToken, targetComment) | |||
There was a problem hiding this comment.
This thing fixes these newlines https://github.com/vuejs/eslint-plugin-vue/pull/1861/files#diff-6ebdd3c21be70e29ce94a2f399884fd220d4fe9bba358ade66b0bceb325d3102L158
Before we took space before the target token and added it after the moving token.
Now we take space after the target token and added it after the moving token.
|
I ran it in my project and the result was great. The only annoying thing left is this: |
FloEdelmann
changed the title
vue/define-macros-order rule
I think we shouldn't add options for auto-fix. Because the aims of the rule is to check. |
In PR #1861 was decided to create separate PR for these improvements
There are two fixes here:
a();b() -> b()a();