Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suggestions for no-template-target-blank rule #2111

Merged
merged 2 commits into from Mar 22, 2023
Merged

Add suggestions for no-template-target-blank rule #2111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9864f1
Add suggestions for `no-template-target-blank` rule
FloEdelmann Mar 21, 2023
80dd9d7
Simplify logic
FloEdelmann Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 29 additions & 1 deletion lib/rules/no-template-target-blank.js
View file
Open in desktop
Expand Up @@ -67,6 +67,32 @@ function hasDynamicLink(node) {
)
}

/**
* @param {VAttribute} node
* @returns {Rule.SuggestionReportDescriptor}
*/
function getSuggestion(node) {
const relAttributeNode = node.parent.attributes.find(
(attribute) => attribute.key.name === 'rel'
)

if (relAttributeNode) {
return {
desc: 'Change `rel` attribute value to `noopener noreferrer`.',
fix(fixer) {
return fixer.replaceText(relAttributeNode, 'rel="noopener noreferrer"')
}
}
}

return {
desc: 'Add `rel="noopener noreferrer"`.',
fix(fixer) {
return fixer.insertTextAfter(node, ' rel="noopener noreferrer"')
}
}
}

module.exports = {
meta: {
type: 'problem',
Expand All @@ -76,6 +102,7 @@ module.exports = {
categories: undefined,
url: 'https://eslint.vuejs.org/rules/no-template-target-blank.html'
},
hasSuggestions: true,
schema: [
{
type: 'object',
Expand Down Expand Up @@ -118,7 +145,8 @@ module.exports = {
context.report({
node,
message:
'Using target="_blank" without rel="noopener noreferrer" is a security risk.'
'Using target="_blank" without rel="noopener noreferrer" is a security risk.',
suggest: [getSuggestion(node)]
})
}
}
Expand Down
60 changes: 55 additions & 5 deletions tests/lib/rules/no-template-target-blank.js
View file
Open in desktop
Expand Up @@ -49,31 +49,81 @@ ruleTester.run('no-template-target-blank', rule, {
{
code: '<template><a href="https://eslint.vuejs.org" target="_blank">link</a></template>',
errors: [
'Using target="_blank" without rel="noopener noreferrer" is a security risk.'
{
message:
'Using target="_blank" without rel="noopener noreferrer" is a security risk.',
suggestions: [
{
desc: 'Add `rel="noopener noreferrer"`.',
output:
'<template><a href="https://eslint.vuejs.org" target="_blank" rel="noopener noreferrer">link</a></template>'
}
]
}
]
},
{
code: '<template><a href="https://eslint.vuejs.org" target="_blank" rel="noopenernoreferrer">link</a></template>',
errors: [
'Using target="_blank" without rel="noopener noreferrer" is a security risk.'
{
message:
'Using target="_blank" without rel="noopener noreferrer" is a security risk.',
suggestions: [
{
desc: 'Change `rel` attribute value to `noopener noreferrer`.',
output:
'<template><a href="https://eslint.vuejs.org" target="_blank" rel="noopener noreferrer">link</a></template>'
}
]
}
]
},
{
code: '<template><a :href="link" target="_blank" rel=3>link</a></template>',
errors: [
'Using target="_blank" without rel="noopener noreferrer" is a security risk.'
{
message:
'Using target="_blank" without rel="noopener noreferrer" is a security risk.',
suggestions: [
{
desc: 'Change `rel` attribute value to `noopener noreferrer`.',
output:
'<template><a :href="link" target="_blank" rel="noopener noreferrer">link</a></template>'
}
]
}
]
},
{
code: '<template><a :href="link" target="_blank">link</a></template>',
errors: [
'Using target="_blank" without rel="noopener noreferrer" is a security risk.'
{
message:
'Using target="_blank" without rel="noopener noreferrer" is a security risk.',
suggestions: [
{
desc: 'Add `rel="noopener noreferrer"`.',
output:
'<template><a :href="link" target="_blank" rel="noopener noreferrer">link</a></template>'
}
]
}
]
},
{
code: '<template><a href="https://eslint.vuejs.org" target="_blank" rel="noopener">link</a></template>',
errors: [
'Using target="_blank" without rel="noopener noreferrer" is a security risk.'
{
message:
'Using target="_blank" without rel="noopener noreferrer" is a security risk.',
suggestions: [
{
desc: 'Change `rel` attribute value to `noopener noreferrer`.',
output:
'<template><a href="https://eslint.vuejs.org" target="_blank" rel="noopener noreferrer">link</a></template>'
}
]
}
]
}
]
Expand Down