Fix siblings and interleaving issues reported in #2342 #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @FloEdelmann, thank you for reporting #2342, I have hopefully addressed those here, please let me know if I missed something. |
2 tasks
FloEdelmann
reviewed
Dec 8, 2023
FloEdelmann
reviewed
Dec 13, 2023
Comment on lines
+39
to
+46
| const siblings = node.parent.children.filter( | ||
| (child) => child.type === 'VElement' | ||
| ) | ||
|
|
||
| return siblings.some( | ||
| (sibling) => | ||
| sibling !== node && | ||
| sibling.type === 'VElement' && |
There was a problem hiding this comment.
If we need to check the element's type anyway in the some predicate, then we can avoid filtering the list before.
Suggested change
| const siblings = node.parent.children.filter( | |
| (child) => child.type === 'VElement' | |
| ) | |
| return siblings.some( | |
| (sibling) => | |
| sibling !== node && | |
| sibling.type === 'VElement' && | |
| return node.parent.children.some( | |
| (sibling) => | |
| sibling !== node && | |
| sibling.type === 'VElement' && |
Comment on lines
+82
to
88
| let needsKey = false | ||
|
|
||
| context.report({ | ||
| node: node.startTag, | ||
| loc: node.startTag.loc, | ||
| messageId: 'requireKey', | ||
| data: { | ||
| componentName | ||
| }, | ||
| fix(fixer) { | ||
| const afterComponentNamePosition = | ||
| node.startTag.range[0] + componentName.length + 1 | ||
| return fixer.insertTextBeforeRange( | ||
| [afterComponentNamePosition, afterComponentNamePosition], | ||
| ` key="${uniqueKey}"` | ||
| ) | ||
| if (node === conditionalFamily.if || node === conditionalFamily.else) { | ||
| needsKey = true | ||
| } else if (conditionalFamily.elseIf.includes(node)) { | ||
| needsKey = true | ||
| } |
There was a problem hiding this comment.
Please replace with a single const:
const needsKey =
conditionalFamily.if === node ||
conditionalFamily.else === node ||
conditionalFamily.elseIf.includes(node)
Comment on lines
+268
to
+270
| // Reset if family already has an 'if' directive | ||
| usageInfo.count = 1 | ||
| usageInfo.firstNode = node |
There was a problem hiding this comment.
Will this work for the following case? Please also add this as a test case:
<ComponentA v-if="foo" />
<ComponentA v-else />
<ComponentA v-if="bar" />
<ComponentA v-else-if="baz" />
<ComponentA v-else />An error should be reported for all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the bugs reported in #2342
And added tests