Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checking for script setup in vue/require-typed-ref #2427

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix checking for script setup in vue/require-typed-ref #2427

wants to merge 3 commits into from
+55 −7

Conversation

kovalchukq
Copy link

No description provided.

FloEdelmann
FloEdelmann reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please fix the lint error (run npm run lint:fix)? Otherwise, this looks good to me.

@ota-meshi
Copy link
Member

Hmm... What is this PR fixing? Could you please explain the details?

@kovalchukq
Copy link
Author

kovalchukq commented Mar 15, 2024 •
edited

Hmm... What is this PR fixing? Could you please explain the details?
This PR skip checking vue/require-typed-ref rule for vue files that doesn't have lang="ts".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann left review comments

@waynzh waynzh waynzh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kovalchukq @ota-meshi @FloEdelmann @waynzh