Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: no-props-shadow #2432

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: no-props-shadow #2432

wants to merge 2 commits into from

Conversation

RiESAEX
Copy link

@RiESAEX RiESAEX commented Mar 21, 2024

closes #2287

RiESAEX
RiESAEX commented Mar 21, 2024
View reviewed changes
lib/rules/no-props-shadow.js
* @returns {propName is string}
*/
(propName) =>
utils.isDef(propName) && !GLOBALS_WHITE_LISTED.has(propName)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there should be another rule disallow people defining props in GLOBALS_WHITE_LISTED?
BTW, I found an obsolete GLOBALS_WHITE_LISTED in "no-mutating-props" but don't know what to do

eslint-plugin-vue/lib/rules/no-mutating-props.js

Lines 14 to 20 in f84b8ee

// https://github.com/vuejs/vue-next/blob/7c11c58faf8840ab97b6449c98da0296a60dddd8/packages/shared/src/globalsWhitelist.ts
const GLOBALS_WHITE_LISTED = new Set([
'Infinity',
'undefined',
'NaN',
'isFinite',
'isNaN',

@RiESAEX
Copy link
Author

RiESAEX commented Mar 28, 2024

@FloEdelmann @ota-meshi hey, Is there anything I can do to make this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule Proposal: vue/no-props-shadow
1 participant
@RiESAEX