Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed false negatives for props in template in vue/no-unused-properties #2435

Merged
merged 4 commits into from Apr 14, 2024
Merged

Fixed false negatives for props in template in vue/no-unused-properties #2435

merged 4 commits into from Apr 14, 2024

Conversation

ItMaga
Copy link
Contributor

@ItMaga ItMaga commented Mar 23, 2024

fixes #2193
fixes #1285

@ItMaga ItMaga requested a review from FloEdelmann April 3, 2024 16:46
FloEdelmann
FloEdelmann approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution in this complicated rule!

ota-meshi
ota-meshi approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit e665b7c into vuejs:master Apr 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ItMaga @FloEdelmann @ota-meshi