Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pinia methods in vue/no-unused-properties #2441

Merged
merged 1 commit into from Apr 14, 2024

Conversation

luizotcarvalho
Copy link
Contributor

@luizotcarvalho luizotcarvalho commented Apr 4, 2024

Changes are aimed at improving Pinia support.

Following Pinia methods will be checked: mapGetters, mapState, mapWritableState and mapActions, when no-unused-properties will be enabled.

Its not possible to support mapStores easily because de result variable is the store id + Store (See more) and would fail always.

Fixes #1675.

@FloEdelmann FloEdelmann changed the title Add support to pinia (#1675) Support Pinia methods in vue/no-unused-properties Apr 4, 2024
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, that was fast! And the code looks good to me. Thanks 🙂

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit a4be0fc into vuejs:master Apr 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vuex and Pinia support
3 participants