Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⭐️New: Add vue/no-deprecated-slot-attribute rule #839
⭐️New: Add vue/no-deprecated-slot-attribute rule #839
Changes from 1 commit
f28bdaa
1ce47a1
bf5f03f
014e6b6
6bbc928
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, sorry, I had overlooked this in the previous review.
In some cases,
slot
andv-slot
should be in different places.v-slot
must be on a<template>
element which is a direct child of a custom element.v-slot
for the default slot can be on a custom element directly if there are no named slots.So in this case, the
<a>
element must be wrapped by a<template>
element.In the example of nested default slots, it will be moved to the parent element.
Therefore, autofix may be tough to implement... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply.
Thank you for pointing this out.
Sorry, I did not understand
v-slot
correctly.I will change it so that it will only autofix if
slot
is attached to<template>
.