fix: delete text should not trigger auto insert

close #2222
vuejs · Dec 18, 2022 · 087f0fa · 087f0fa
1 parent 877d3c0
commit 087f0fa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/packages/language-server/src/registerFeatures.ts b/packages/language-server/src/registerFeatures.ts
@@ -74,11 +74,7 @@ export function setupSyntacticCapabilities(
 		// https://github.com/microsoft/vscode/blob/ce119308e8fd4cd3f992d42b297588e7abe33a0c/extensions/typescript-language-features/src/languageFeatures/formatting.ts#L99
 		server.documentOnTypeFormattingProvider = {
 			firstTriggerCharacter: ';',
-			moreTriggerCharacter: [
-				'}',
-				'\n',
-				'{', // addSpaceBetweenDoubleCurlyBrackets
-			],
+			moreTriggerCharacter: ['}', '\n'],
 		};
 	}
 }

diff --git a/packages/vscode-language-client/src/features/autoInsertion.ts b/packages/vscode-language-client/src/features/autoInsertion.ts
@@ -30,7 +30,13 @@ export async function register(
 	}
 
 	function onDidChangeTextDocument({ document, contentChanges, reason }: vscode.TextDocumentChangeEvent) {
-		if (!isEnabled || contentChanges.length === 0 || reason === vscode.TextDocumentChangeReason.Undo || reason === vscode.TextDocumentChangeReason.Redo) {
+		if (
+			!isEnabled
+			|| contentChanges.length !== 1
+			|| !contentChanges[0].text // delete
+			|| reason === vscode.TextDocumentChangeReason.Undo
+			|| reason === vscode.TextDocumentChangeReason.Redo
+		) {
 			return;
 		}
 		const activeDocument = vscode.window.activeTextEditor?.document;