fix: don't reference template types if component have no any slot

close #1708
vuejs · Aug 27, 2022 · 28e8f92 · 28e8f92
1 parent 6f79f8f
commit 28e8f92
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/vue-language-core/src/generators/script.ts b/packages/vue-language-core/src/generators/script.ts
@@ -431,7 +431,12 @@ export function generate(
 
 			writeTemplate();
 
-			codeGen.addText(`return {} as typeof __VLS_Component & (new () => { ${getSlotsPropertyName(vueVersion)}: ReturnType<typeof __VLS_template> });\n`);
+			if (htmlGen?.slotsNum) {
+				codeGen.addText(`return {} as typeof __VLS_Component & (new () => { ${getSlotsPropertyName(vueVersion)}: ReturnType<typeof __VLS_template> });\n`);
+			}
+			else {
+				codeGen.addText(`return {} as typeof __VLS_Component;\n`);
+			}
 
 			codeGen.addText(`};\n`);
 			codeGen.addText(`return await __VLS_setup();\n`);

diff --git a/packages/vue-language-core/src/generators/template.ts b/packages/vue-language-core/src/generators/template.ts
@@ -90,6 +90,7 @@ export function generate(
 	const identifiers = new Set<string>();
 	const scopedClasses: { className: string, offset: number; }[] = [];
 	const blockConditions: string[] = [];
+	let slotsNum = 0;
 
 	tsFormatCodeGen.addText('export { };\n');
 
@@ -246,6 +247,7 @@ export function generate(
 	}
 	tsCodeGen.addText(`{\n`);
 	for (const [name, slot] of slots) {
+		slotsNum++;
 		writeObjectProperty(
 			name,
 			slot.loc,
@@ -270,6 +272,7 @@ export function generate(
 		cssCodeGen: cssCodeGen,
 		tagNames: tagOffsetsMap,
 		identifiers,
+		slotsNum,
 	};
 
 	function visitNode(node: CompilerDOM.TemplateChildNode, parentEl: CompilerDOM.ElementNode | undefined): void {