fix: attrs auto-complete and tag highlight incorrect on js project

close #1158
vuejs · Apr 11, 2022 · 31e6a2b · 31e6a2b
1 parent d004ad2
commit 31e6a2b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/vue-language-service/src/vuePlugins/vueTemplateLanguage.ts b/packages/vue-language-service/src/vuePlugins/vueTemplateLanguage.ts
@@ -758,20 +758,20 @@ export default function <T extends ReturnType<typeof useHtmlPlugin>>(options: {
                         let offset = file.content.indexOf(searchText);
                         if (offset >= 0) {
                             offset += searchText.length;
-                            bind = options.tsRuntime.getTsLs().getCompletionsAtPosition(file.fileName, offset, undefined)?.entries ?? [];
+                            bind = options.tsRuntime.getTsLs().getCompletionsAtPosition(file.fileName, offset, undefined)?.entries.filter(entry => entry.kind !== 'warning') ?? [];
                         }
                     }
                     {
                         const searchText = SearchTexts.EmitCompletion(tag.name);
                         let offset = file.content.indexOf(searchText);
                         if (offset >= 0) {
                             offset += searchText.length;
-                            on = options.tsRuntime.getTsLs().getCompletionsAtPosition(file.fileName, offset, undefined)?.entries ?? [];
+                            on = options.tsRuntime.getTsLs().getCompletionsAtPosition(file.fileName, offset, undefined)?.entries.filter(entry => entry.kind !== 'warning') ?? [];
                         }
                     }
                     cache.set(tag.name, { item: tag.item, bind, on });
                 }
-                const globalBind = options.tsRuntime.getTsLs().getCompletionsAtPosition(file.fileName, file.content.indexOf(SearchTexts.GlobalAttrs), undefined)?.entries ?? [];
+                const globalBind = options.tsRuntime.getTsLs().getCompletionsAtPosition(file.fileName, file.content.indexOf(SearchTexts.GlobalAttrs), undefined)?.entries.filter(entry => entry.kind !== 'warning') ?? [];
                 cache.set('*', { item: undefined, bind: globalBind, on: [] });
             }
 

diff --git a/packages/vue-typescript/src/vueFile.ts b/packages/vue-typescript/src/vueFile.ts
@@ -527,7 +527,7 @@ export function createVueFile(
 			// getSourceFile return undefined for lang=js with allowJs=false;
 			!!tsLs.getProgram()?.getSourceFile(file.fileName);
 
-		let components = hasFile ? tsLs.getCompletionsAtPosition(file!.fileName, file!.content.indexOf(SearchTexts.Components), options)?.entries ?? [] : [];
+		let components = hasFile ? tsLs.getCompletionsAtPosition(file!.fileName, file!.content.indexOf(SearchTexts.Components), options)?.entries.filter(entry => entry.kind !== ts.ScriptElementKind.warning) ?? [] : [];
 
 		components = components.filter(entry => {
 			return entry.name.indexOf('$') === -1 && !entry.name.startsWith('_');