fix: don't combine emmet completion with embedded languages completion

close #1039
vuejs · Mar 20, 2022 · 67d3bdf · 67d3bdf
1 parent cd182f6
commit 67d3bdf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/packages/vue-language-service/src/languageFuatures/complete.ts b/packages/vue-language-service/src/languageFuatures/complete.ts
@@ -151,7 +151,7 @@ export function register(context: LanguageServiceRuntimeContext) {
 
 							const embeddedCompletionList = await plugin.doComplete(sourceMap.mappedDocument, embeddedRange.start, completionContext);
 
-							if (!embeddedCompletionList)
+							if (!embeddedCompletionList || !embeddedCompletionList.items.length)
 								continue;
 
 							if (!plugin.context?.isAdditionalCompletion) {
@@ -212,7 +212,7 @@ export function register(context: LanguageServiceRuntimeContext) {
 
 					const completionList = await plugin.doComplete(document, position, completionContext);
 
-					if (!completionList)
+					if (!completionList || !completionList.items.length)
 						continue;
 
 					if (!plugin.context?.isAdditionalCompletion) {

diff --git a/packages/vue-language-service/src/languageService.ts b/packages/vue-language-service/src/languageService.ts
@@ -156,9 +156,6 @@ export function createLanguageService(
 		useEmmetPlugin({
 			configurationHost,
 		}),
-		{
-			isAdditionalCompletion: true,
-		},
 	);
 	const scriptTsPlugin = useTsPlugins(
 		scriptTsLs,