fix: wrong check for whether jsx option is set (#1595)

Co-authored-by: johnsoncodehk <johnsoncodehk@gmail.com>
vuejs · Jul 19, 2022 · 834a866 · 834a866
1 parent 662ee29
commit 834a866
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/docs/installation.md b/docs/installation.md
@@ -65,6 +65,7 @@ In order to support Vue 2 templates you need to edit your `tsconfig.json` file
 ```jsonc{6}
 {
   "compilerOptions": {
+    "jsx": "preserve",
     // ...
   },
   "vueCompilerOptions": {
@@ -106,4 +107,4 @@ Check out the [Troubleshooting](troubleshooting.md) page
 #### Additional features?
 
 Check out additional Volar [Features](features.md)
-
+
diff --git a/packages/vue-typescript/src/sourceFile.ts b/packages/vue-typescript/src/sourceFile.ts
@@ -258,7 +258,7 @@ export function createSourceFile(
 			scriptSetupRanges,
 			scriptLang,
 			vueCompilerOptions,
-			!!vueCompilerOptions.experimentalDisableTemplateSupport || (compilerOptions.jsx ?? ts.JsxEmit.Preserve) !== ts.JsxEmit.Preserve,
+			!!vueCompilerOptions.experimentalDisableTemplateSupport || compilerOptions.jsx !== ts.JsxEmit.Preserve,
 			fileName.endsWith('.html') // petite-vue
 		),
 	];
@@ -529,7 +529,7 @@ export function createSourceFile(
 		getSfcRefSugarRanges: () => sfcRefSugarRanges.value,
 		getEmbeddeds: () => embeddeds.value,
 		getScriptSetupRanges: () => scriptSetupRanges.value,
-		isJsxMissing: () => !vueCompilerOptions.experimentalDisableTemplateSupport && (compilerOptions.jsx ?? ts.JsxEmit.Preserve) !== ts.JsxEmit.Preserve,
+		isJsxMissing: () => !vueCompilerOptions.experimentalDisableTemplateSupport && compilerOptions.jsx !== ts.JsxEmit.Preserve,
 
 		getAllEmbeddeds: () => allEmbeddeds.value,
 		getTeleports: () => teleports.value,