refactor: remove extra props hover info logic due to upstream resolved

vuejs/core#5166
vuejs · Dec 26, 2021 · 8dd5b1c · 8dd5b1c
1 parent e339424
commit 8dd5b1c
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 19 deletions.
diff --git a/packages/vscode-vue-languageservice/src/services/hover.ts b/packages/vscode-vue-languageservice/src/services/hover.ts
@@ -29,7 +29,7 @@ export function register({ sourceFiles, htmlLs, pugLs, getCssLs, getTsLs, vueHos
 		return result;
 	}
 
-	function onTs(uri: string, position: vscode.Position, isExtra = false) {
+	function onTs(uri: string, position: vscode.Position) {
 
 		let result: vscode.Hover | undefined;
 
@@ -48,25 +48,9 @@ export function register({ sourceFiles, htmlLs, pugLs, getCssLs, getTsLs, vueHos
 			const tsHover = tsLs.doHover(
 				tsLoc.uri,
 				tsLoc.range.start,
-				isExtra,
 			);
 			if (!tsHover) continue;
 
-			if (!isExtra && tsLoc.type === 'embedded-ts' && tsLoc.data.capabilities.extraHoverInfo) {
-				const definitions = findDefinitions.on(uri, position) as vscode.LocationLink[];
-				for (const definition of definitions) {
-					const extraHover = onTs(definition.targetUri, definition.targetSelectionRange.start, true);
-					if (!extraHover) continue;
-					if (!vscode.MarkupContent.is(extraHover.contents)) continue;
-					const extraText = extraHover.contents.value;
-					for (const extraTextPart of extraText.split('\n\n')) {
-						if (vscode.MarkupContent.is(tsHover.contents) && !tsHover.contents.value.split('\n\n').includes(extraTextPart)) {
-							tsHover.contents.value += `\n\n` + extraTextPart;
-						}
-					}
-				}
-			}
-
 			if (tsHover.range) {
 				// ts -> vue
 				const hoverRange = { start: position, end: position };

diff --git a/packages/vue-code-gen/src/generators/template.ts b/packages/vue-code-gen/src/generators/template.ts
@@ -13,7 +13,7 @@ const capabilitiesSet = {
 	tagHover: { basic: true },
 	event: { basic: true, diagnostic: true },
 	tagReference: { references: true, definitions: true, rename: true, },
-	attr: { basic: true, extraHoverInfo: true, diagnostic: true, references: true, definitions: true, rename: true, },
+	attr: { basic: true, diagnostic: true, references: true, definitions: true, rename: true, },
 	attrReference: { references: true, definitions: true, rename: true, },
 	scopedClassName: { references: true, definitions: true, rename: true, },
 	slotName: { basic: true, diagnostic: true, references: true, definitions: true, completion: true, },

diff --git a/packages/vue-code-gen/src/types.ts b/packages/vue-code-gen/src/types.ts
@@ -5,7 +5,6 @@ export interface TsMappingData {
 	doRename?: (oldName: string, newName: string) => string,
 	capabilities: {
 		basic?: boolean,
-		extraHoverInfo?: boolean,
 		references?: boolean,
 		definitions?: boolean,
 		diagnostic?: boolean,