feat: add experimentalSuppressUnknownPropErrors option

#1077
vuejs · Jun 4, 2022 · ab5313a · ab5313a
1 parent 2a78f39
commit ab5313a
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/extensions/vscode-vue-language-features/schemas/vue-tsconfig.schema.json b/extensions/vscode-vue-language-features/schemas/vue-tsconfig.schema.json
@@ -66,6 +66,10 @@
 					"type": "boolean",
 					"markdownDescription": "https://github.com/johnsoncodehk/volar/issues/1369"
 				},
+				"experimentalSuppressUnknownJsxPropertyErrors": {
+					"type": "boolean",
+					"markdownDescription": "Suppress unknown property errors in JSX and template. (Default true)"
+				},
 				"experimentalResolveStyleCssClasses": {
 					"enum": [
 						"scoped",

diff --git a/packages/vue-typescript/src/types.ts b/packages/vue-typescript/src/types.ts
@@ -20,5 +20,6 @@ export interface VueCompilerOptions {
 	experimentalDisableTemplateSupport?: boolean;
 	experimentalResolveStyleCssClasses?: 'scoped' | 'always' | 'never';
 	experimentalAllowTypeNarrowingInInlineHandlers?: boolean;
+	experimentalSuppressUnknownJsxPropertyErrors?: boolean;
 	experimentalUseScriptLeadingCommentInTemplate?: boolean;
 }
diff --git a/packages/vue-typescript/src/typescriptRuntime.ts b/packages/vue-typescript/src/typescriptRuntime.ts
@@ -29,7 +29,7 @@ export function createTypeScriptRuntime(options: {
 }) {
 
 	const { typescript: ts } = options;
-	const vueVersion = options.vueLsHost.getVueCompilationSettings().experimentalCompatMode ?? 3;
+	const vueCompilerOptions = options.vueLsHost.getVueCompilationSettings();
 	const tsFileVersions = new Map<string, string>();
 	const vueFiles = createVueFiles();
 	const plugins = [
@@ -38,7 +38,7 @@ export function createTypeScriptRuntime(options: {
 	];
 	const tsLsHost = createTsLsHost();
 	const tsLsRaw = ts.createLanguageService(tsLsHost);
-	const localTypesScript = ts.ScriptSnapshot.fromString(localTypes.getTypesCode(vueVersion));
+	const localTypesScript = ts.ScriptSnapshot.fromString(localTypes.getTypesCode(vueCompilerOptions.experimentalCompatMode ?? 3));
 
 	let lastProjectVersion: string | undefined;
 	let tsProjectVersion = 0;
@@ -58,7 +58,7 @@ export function createTypeScriptRuntime(options: {
 		},
 		getLocalTypesFiles: () => {
 			const fileNames = getLocalTypesFiles();
-			const code = localTypes.getTypesCode(vueVersion);
+			const code = localTypes.getTypesCode(vueCompilerOptions.experimentalCompatMode ?? 3);
 			return {
 				fileNames,
 				code,
@@ -279,6 +279,15 @@ export function createTypeScriptRuntime(options: {
 			}
 			let tsScript = options.vueLsHost.getScriptSnapshot(fileName);
 			if (tsScript) {
+				if ((vueCompilerOptions.experimentalSuppressUnknownJsxPropertyErrors ?? true) && basename === 'runtime-dom.d.ts') {
+					// allow arbitrary attributes
+					let tsScriptText = tsScript.getText(0, tsScript.getLength());
+					tsScriptText = tsScriptText.replace(
+						'type ReservedProps = {',
+						'type ReservedProps = { [name: string]: any',
+					);
+					tsScript = ts.ScriptSnapshot.fromString(tsScriptText);
+				}
 				scriptSnapshots.set(fileName.toLowerCase(), [version, tsScript]);
 				return tsScript;
 			}