Skip to content

Commit

Permalink
chore: change publisher
Browse files Browse the repository at this point in the history 
close #1124
  • Loading branch information
@johnsoncodehk
johnsoncodehk committed May 2, 2022
1 parent 55bca29 commit afd4f4b
Show file tree
Hide file tree
Showing 6 changed files with 44 additions and 44 deletions.
2 changes: 1 addition & 1 deletion extensions/vscode-typescript-vue-plugin/README.md
View file
Expand Up @@ -2,7 +2,7 @@

> A [TS server plugin](https://github.com/microsoft/TypeScript/wiki/Writing-a-Language-Service-Plugin) to make TS server know *.vue files.
[Plugin's page on Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=johnsoncodehk.vscode-typescript-vue-plugin)
[Plugin's page on Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=Vue.vscode-typescript-vue-plugin)

⚠️ It's recommended to [use take over mode instead of this plugin](https://github.com/johnsoncodehk/volar/discussions/471).

Expand Down
2 changes: 1 addition & 1 deletion extensions/vscode-typescript-vue-plugin/package.json
View file
Expand Up @@ -10,7 +10,7 @@
"displayName": "TypeScript Vue Plugin (Volar)",
"description": "Vue Plugin for TypeScript server",
"author": "johnsoncodehk",
"publisher": "johnsoncodehk",
"publisher": "Vue",
"engines": {
"vscode": "*"
},
Expand Down
2 changes: 1 addition & 1 deletion extensions/vscode-vue-language-features/README.md
View file
Expand Up @@ -2,7 +2,7 @@

> ⚡ Fast Vue Language Support Extension
[Plugin's page on Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=johnsoncodehk.volar)
[Plugin's page on Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=Vue.volar)

VueLF is a Language Support plugin built specifically for Vue 3. It's based on [`@vue/reactivity`](https://www.npmjs.com/package/@vue/reactivity) to calculate everything on-demand, to implement native TypeScript language service level performance.

Expand Down
2 changes: 1 addition & 1 deletion extensions/vscode-vue-language-features/package.json
View file
Expand Up @@ -11,7 +11,7 @@
"displayName": "Vue Language Features (Volar)",
"description": "Language support for Vue 3",
"author": "johnsoncodehk",
"publisher": "johnsoncodehk",
"publisher": "Vue",
"engines": {
"vscode": "^1.63.0"
},
Expand Down
2 changes: 1 addition & 1 deletion extensions/vscode-vue-language-features/src/features/createWorkspaceSnippets.ts
View file
Expand Up @@ -6,7 +6,7 @@ export async function activate(context: vscode.ExtensionContext) {
if (vscode.workspace.workspaceFolders) {
for (const rootPath of vscode.workspace.workspaceFolders) {

const volar = vscode.extensions.getExtension('johnsoncodehk.volar');
const volar = vscode.extensions.getExtension('Vue.volar');
if (!volar) return;

const templateUri = vscode.Uri.joinPath(volar.extensionUri, 'templates', 'vue.code-snippets');
Expand Down
78 changes: 39 additions & 39 deletions pnpm-lock.yaml
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 comments on commit afd4f4b

@crunchwrap89
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Something happened after this commit.
I get an error message in VS Code saying:

The 2 extension(s) below, in workspace recommendations have issues: 
johnsoncodehk.volar (not found in marketplace)
johnsoncodehk.vscode-typescript-vue-plugin (not found in marketplace)

Reinstalling / Reloading the window does not help.

@johnsoncodehk
Copy link
Member Author

@johnsoncodehk johnsoncodehk commented on afd4f4b May 2, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @crunchwrap89, please change extensions id to Vue.volar and Vue.vscode-typescript-vue-plugin in .vscode/extensions.json.

@crunchwrap89
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @crunchwrap89, please change extensions id to Vue.volar and Vue.vscode-typescript-vue-plugin in .vscode/extensions.json.

Hi,
I didnt realise i had this file, yes it works after changing this.
Thank you!

@emikoshi
Copy link

@emikoshi emikoshi commented on afd4f4b May 3, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, also running into an issue since this update (was running 0.34.10 fine). I did update the extensions recommendations as the poster above mentioned, those warnings went away just fine.

Though I can't seem to have the install 'stick' when installing on the remote server/run in the remote extension host. After the normal local installation, it correctly recommends to install remotely. But if the vscode window is reloaded or app is closed/reopened, the extension seems to disappear and does not work. I have to go through the installation process all over again. Also to add to this, the extension fails to ever be included in the section where remote extensions are listed, which I suppose makes sense.

EDIT:
This was a little tricky to figure out. For anyone that may encounter this there is an .obsolete file located under .vscode/extensions (could be local or remote, depending where your problem may be) mine had "johnsoncodehk.volar-0.34.11-linux-x64":true as an entry. Once I removed that I uninstalled volar and reinstalled, everything working great again as intended!

@johnsoncodehk
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emikoshi Thanks for your sharing! For me, totally restart vscode (not just use reload window command) and reinstall extension fix the problem.

Please sign in to comment.