Throw an error when `composite` is enabled #2622

sxzz · 2023-04-18T12:03:57Z

Reproduction: https://github.com/sxzz/volar-starter/commit/e83eb070283dc0c06692b5d1bf7c4e486419e559

/project/node_modules/.pnpm/vue-tsc@1.3.16_typescript@5.0.4/node_modules/vue-tsc/bin/vue-tsc.js:53
                        throw err;
                        ^

Error: Debug Failure. False expression: Paths must either both be absolute or both be relative
    at getRelativePathFromDirectory (/project/node_modules/.pnpm/typescript@5.0.4/node_modules/typescript/lib/tsc.js:5717:9)
    at relativeToBuildInfo (/project/node_modules/.pnpm/typescript@5.0.4/node_modules/typescript/lib/tsc.js:117152:38)
    at convertToReusableDiagnosticRelatedInformation (/project/node_modules/.pnpm/typescript@5.0.4/node_modules/typescript/lib/tsc.js:117237:18)
    at /project/node_modules/.pnpm/typescript@5.0.4/node_modules/typescript/lib/tsc.js:117223:20
    at Array.map (<anonymous>)
    at convertToReusableDiagnostics (/project/node_modules/.pnpm/typescript@5.0.4/node_modules/typescript/lib/tsc.js:117222:22)
    at getBuildInfo2 (/project/node_modules/.pnpm/typescript@5.0.4/node_modules/typescript/lib/tsc.js:117099:11)
    at newProgram.getBuildInfo (/project/node_modules/.pnpm/typescript@5.0.4/node_modules/typescript/lib/tsc.js:117309:41)
    at Object.getBuildInfo (/project/node_modules/.pnpm/typescript@5.0.4/node_modules/typescript/lib/typescript.js:116651:70)
    at emitBuildInfo (/project/node_modules/.pnpm/typescript@5.0.4/node_modules/typescript/lib/typescript.js:109453:30)

The text was updated successfully, but these errors were encountered:

Mostaard · 2023-04-25T09:21:09Z

I'm encountering the same issue

stefanprobst · 2023-04-26T06:06:27Z

i am getting the same error with "incremental": true

vikingair · 2023-04-26T13:14:57Z

I have the same error with version 1.4.4. Funnily, when downgrading to 1.4.0 I get a different error:

composite / incremental is not supported

The error still exists in 1.5.3.

In version 1.3.9 it still works and it breaks using version higher than 1.3.10

Update: For some reason the version 1.3.9 only worked locally, but didn't pass the pipeline checks 🤔

FabianMontoya · 2023-05-02T14:44:15Z

I have the same error:

Running npm run type-check that execute vue-tsc --noEmit

> vue-tsc --noEmit

[root path...]/vue-app/node_modules/vue-tsc/bin/vue-tsc.js:53
			throw err;
			^

Error: Debug Failure. False expression: Paths must either both be absolute or both be relative
    at getRelativePathFromDirectory (.../vue-app/node_modules/typescript/lib/tsc.js:5717:9)
    at relativeToBuildInfo (.../vue-app/node_modules/typescript/lib/tsc.js:117152:38)
    at convertToReusableDiagnosticRelatedInformation (.../vue-app/node_modules/typescript/lib/tsc.js:117237:18)
    at .../vue-app/node_modules/typescript/lib/tsc.js:117223:20
    at Array.map (<anonymous>)
    at convertToReusableDiagnostics (.../vue-app/node_modules/typescript/lib/tsc.js:117222:22)
    at getBuildInfo2 (.../vue-app/node_modules/typescript/lib/tsc.js:117099:11)
    at newProgram.getBuildInfo (.../vue-app/node_modules/typescript/lib/tsc.js:117309:41)
    at Object.getBuildInfo (.../vue-app/node_modules/typescript/lib/typescript.js:116651:70)
    at emitBuildInfo (.../vue-app/node_modules/typescript/lib/typescript.js:109453:30)

Node.js v18.14.2

"devDependencies": {
    "@tsconfig/node18": "^2.0.0",
    "@types/node": "^18.16.2",
    "@vitejs/plugin-vue": "^4.2.1",
    "@vue/tsconfig": "^0.3.2",
    "typescript": "~5.0.4",
    "vite": "^4.3.3",
    "vue-tsc": "^1.6.1"
  }

Ragura · 2023-05-10T15:15:32Z

This is also blocking us from upgrading.
Current related versions:
"typescript": "5.0.4"
"vue-tsc": "^1.6.4"

Contents of tsconfig:

{
  "compilerOptions": {
    "module": "ESNext",
    "target": "ESNext",
    "moduleResolution": "node",
    "lib": [
      "DOM",
      "ESNext",
      "DOM.Iterable"
    ],
    "baseUrl": ".",
    "rootDir": "src",
    "strict": true,
    "alwaysStrict": true,
    "isolatedModules": true,
    "importsNotUsedAsValues": "error",
    "useDefineForClassFields": true,
    "esModuleInterop": false,
    "allowSyntheticDefaultImports": true,
    "resolveJsonModule": true,
    "skipLibCheck": true,
    "strictNullChecks": true,
    "noImplicitThis": true,
    "strictPropertyInitialization": true,
    "forceConsistentCasingInFileNames": true,
    "jsx": "preserve",
    "declaration": true,
    "declarationMap": true,
    "declarationDir": "dist",
    "outDir": "dist",
    "sourceMap": true,
    "composite": true,
    "types": [
      "vite/client",
      "vitest"
    ]
  },
  "paths": {
    "@apps/*": [
      "apps/*/src"
    ],
    "@packages/*": [
      "packages/*/src"
    ]
  },
  "exclude": [
    "node_modules"
  ],
}

FabianMontoya · 2023-05-10T18:28:46Z

I have the same error:

Running npm run type-check that execute vue-tsc --noEmit

> vue-tsc --noEmit

[root path...]/vue-app/node_modules/vue-tsc/bin/vue-tsc.js:53
			throw err;
			^

Error: Debug Failure. False expression: Paths must either both be absolute or both be relative
    at getRelativePathFromDirectory (.../vue-app/node_modules/typescript/lib/tsc.js:5717:9)
    at relativeToBuildInfo (.../vue-app/node_modules/typescript/lib/tsc.js:117152:38)
    at convertToReusableDiagnosticRelatedInformation (.../vue-app/node_modules/typescript/lib/tsc.js:117237:18)
    at .../vue-app/node_modules/typescript/lib/tsc.js:117223:20
    at Array.map (<anonymous>)
    at convertToReusableDiagnostics (.../vue-app/node_modules/typescript/lib/tsc.js:117222:22)
    at getBuildInfo2 (.../vue-app/node_modules/typescript/lib/tsc.js:117099:11)
    at newProgram.getBuildInfo (.../vue-app/node_modules/typescript/lib/tsc.js:117309:41)
    at Object.getBuildInfo (.../vue-app/node_modules/typescript/lib/typescript.js:116651:70)
    at emitBuildInfo (.../vue-app/node_modules/typescript/lib/typescript.js:109453:30)

Node.js v18.14.2

"devDependencies": {
    "@tsconfig/node18": "^2.0.0",
    "@types/node": "^18.16.2",
    "@vitejs/plugin-vue": "^4.2.1",
    "@vue/tsconfig": "^0.3.2",
    "typescript": "~5.0.4",
    "vite": "^4.3.3",
    "vue-tsc": "^1.6.1"
  }

I found that the error was a type error, but the type-check didn't show where was the error, only that throw, I had to open file by file and try to found where was the error and fixed it. 😠💀

Ragura · 2023-05-10T19:24:11Z

@FabianMontoya That's interesting, though it wouldn't explain why there is suddenly a type error to begin with after upgrading to the newer version. Do you remember what the type error was that you fixed? Perhaps it would give us an indication of where to look.

FabianMontoya · 2023-05-10T19:38:22Z

@FabianMontoya That's interesting, though it wouldn't explain why there is suddenly a type error to begin with after upgrading to the newer version. Do you remember what the type error was that you fixed? Perhaps it would give us an indication of where to look.

It was a error in a :key, I had an object and I was passing it as a value of the :key prop of a component, and it had an error said that I can't pass an object as value, only a string | number and I don't remember what else haha, but I only changed :key="myObject" to :key="myObject.id"; but it wasn't the only error, in other places I was getting errors of type, and I was getting the same throw err in the console.

Fixes vuejs#2622 I don't know the exact detail of the crash, but I find that tsc crashed because the `diagnostic.file` object is somehow missing a `resolvedPath` field. Meanwhile, the `fileName` field is always present. So I just added a fallback to `fileName` in the patch. Maybe related: microsoft/TypeScript#54057 I only add it to the 5.0 branch because I haven't tested it on 4.x, so let's play it safe.

@segevfiner

Fixes #267 Thanks @segevfiner for noticing this new feature! Currently there's still a small annoyance that `vue-tsc` would output an extra error message when there're type errors in `.vue` files vuejs/language-tools#2622 But it works well if there's no error. I've already submitted a PR to address it vuejs/language-tools#3176

Ragura · 2023-05-12T11:12:37Z

I can confirm the report by @FabianMontoya and add some more information. In our own project, when we set composite: true in tsconfig.json, we get the Debug Failure. False expression: Paths must either both be absolute or both be relative error. However, when it is set to false, we see normal typescript errors. When fixing these errors and once again setting composite: true, the path error also goes away.
As such, it appears the composite setting will throw the error when even one typescript error is found in the code AND not report that error.
I don't know if the current PR related to this has taken this into account, but if so, thanks for the work!

Shujee · 2023-08-17T19:13:08Z

@Ragura Thank you for sharing that piece of information. In my case, changing composite to false simply builds the output correctly, without any errors. When I set it to true again, I see the dreaded Debug Failure. False expression: Paths must either both be absolute or both be relative message again. Not sure what composite really does, but I guess I can live without it for now.

alessandrolattao · 2023-08-29T08:04:10Z

@Ragura Thank you for sharing that piece of information. In my case, changing composite to false simply builds the output correctly, without any errors. When I set it to true again, I see the dreaded Debug Failure. False expression: Paths must either both be absolute or both be relative message again. Not sure what composite really does, but I guess I can live without it for now.

Same behaviour here :)

johnsoncodehk closed this as completed in 32b8dd7 Apr 20, 2023

johnsoncodehk added the bug label Apr 20, 2023

johnsoncodehk reopened this Apr 22, 2023

vikingair mentioned this issue Apr 27, 2023

v1.5.0+ has confilct with typescript v5.0.4 when use type check #2732

Closed

haoqunjiang mentioned this issue May 12, 2023

fix: patch tsc to not crash on composite project errors #3176

Closed

haoqunjiang mentioned this issue May 12, 2023

fix: use --build for type-checking to be exhaustive and less-fragile vuejs/create-vue#274

Merged

johnsoncodehk closed this as completed in volarjs/volar.js@c8cd804 May 13, 2023

johnsoncodehk added a commit that referenced this issue May 13, 2023

chore: bump @volar/typescript for fix #2622

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

4e05639

BenShelton mentioned this issue Jul 5, 2023

Build failed, error thrown #3345

Closed

jcesarmobile mentioned this issue Jul 31, 2023

bug: Installing capacitor on a default vuetify project fails ionic-team/capacitor#6777

Closed

blake-newman mentioned this issue Sep 12, 2023

fix(vue-tsc): prevent rebuild in incremental mode throwing error #3556

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Throw an error when `composite` is enabled #2622

Throw an error when `composite` is enabled #2622

sxzz commented Apr 18, 2023

Mostaard commented Apr 25, 2023

stefanprobst commented Apr 26, 2023

vikingair commented Apr 26, 2023 •

edited

Loading

FabianMontoya commented May 2, 2023 •

edited

Loading

Ragura commented May 10, 2023

FabianMontoya commented May 10, 2023

Ragura commented May 10, 2023

FabianMontoya commented May 10, 2023

Ragura commented May 12, 2023

Shujee commented Aug 17, 2023

alessandrolattao commented Aug 29, 2023

Throw an error when composite is enabled #2622

Throw an error when composite is enabled #2622

Comments

sxzz commented Apr 18, 2023

Mostaard commented Apr 25, 2023

stefanprobst commented Apr 26, 2023

vikingair commented Apr 26, 2023 • edited Loading

FabianMontoya commented May 2, 2023 • edited Loading

Ragura commented May 10, 2023

FabianMontoya commented May 10, 2023

Ragura commented May 10, 2023

FabianMontoya commented May 10, 2023

Ragura commented May 12, 2023

Shujee commented Aug 17, 2023

alessandrolattao commented Aug 29, 2023

Throw an error when `composite` is enabled #2622

Throw an error when `composite` is enabled #2622

vikingair commented Apr 26, 2023 •

edited

Loading

FabianMontoya commented May 2, 2023 •

edited

Loading