fix: patch tsc to not crash on composite project errors #3176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vuejs#2622 I don't know the exact detail of the crash, but I find that tsc crashed because the `diagnostic.file` object is somehow missing a `resolvedPath` field. Meanwhile, the `fileName` field is always present. So I just added a fallback to `fileName` in the patch. Maybe related: microsoft/TypeScript#54057 I only add it to the 5.0 branch because I haven't tested it on 4.x, so let's play it safe.
sodatea
added a commit
to vuejs/create-vue
that referenced
this pull request
May 12, 2023
Fixes #267 Thanks @segevfiner for noticing this new feature! Currently there's still a small annoyance that `vue-tsc` would output an extra error message when there're type errors in `.vue` files vuejs/language-tools#2622 But it works well if there's no error. I've already submitted a PR to address it vuejs/language-tools#3176
|
Thanks for the PR, we avoided it from the source ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2622
I don't know the exact detail of the crash, but I find that tsc crashed because the
diagnostic.fileobject is somehow missing aresolvedPathfield. Meanwhile, thefileNamefield is always present. So I just added a fallback tofileNamein the patch.Maybe related: microsoft/TypeScript#54057
I only add it to the 5.0 branch because I haven't tested it on 4.x, so let's play it safe.