Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set style property to "" instead of to undefined #1755

Merged
merged 1 commit into from Aug 26, 2022
Merged

Set style property to "" instead of to undefined #1755

merged 1 commit into from Aug 26, 2022

Conversation

2-5
Copy link
Contributor

@2-5 2-5 commented Aug 23, 2022

Fixes #1560

In some cases the template generator sets the style property to undefined , which is not accepted by TypeScript when exactOptionalPropertyTypes: true in tsconfig.json.

This PR changes the template generator to emit empty string ("") instead of undefined for style in those cases.

@johnsoncodehk johnsoncodehk merged commit af9b2ca into vuejs:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template style attribute appears undefined when tsconfig exactOptionalPropertyTypes is true
2 participants
@2-5 @johnsoncodehk