fix: use definition from defineProps if possible
#3838
+123
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay, I think this problem is best solved by |
|
I didn't try this approach, but I think making changes to |
johnsoncodehk
force-pushed
the
master
branch
4 times, most recently
from
d0abf57
to
aab3a8a
Compare
|
#3779, #3820 should have been resolved via vuejs/core#10801 + 68edc1d. I reverted the PR's fix but kept the tests, but there are some other tests that are broken due to a regression in Vue 3.5, so they can't be merged for now. |
rchl
reviewed
May 2, 2024
Comment on lines
+31
to
+38
| "pnpm": { | ||
| "overrides": { | ||
| "@vue/runtime-dom": "alpha", | ||
| "@vue/shared": "alpha", | ||
| "@vue/compiler-dom": "alpha", | ||
| "@vue/compiler-sfc": "alpha", | ||
| "vue": "alpha" | ||
| } |
There was a problem hiding this comment.
Wouldn't doing overrides at this level also affect/break vue 2 tests?
There was a problem hiding this comment.
It does not affect Vue 2 tests. Since this PR will only be merged when Vue 3.5 is released, this json section will be removed before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3779, fixes #3820