fix: opt in to import.meta.* properties
#2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pinia-playground canceled.
|
✅ Deploy Preview for pinia-official ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v2 #2622 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 11 11
Lines 2886 2886
Branches 190 190
=======================================
Hits 2754 2754
Misses 131 131
Partials 1 1 ☔ View full report in Codecov by Sentry. |
posva
approved these changes
Mar 25, 2024
niceplugin
added a commit
to niceplugin/Vuejs-Pinia-KO
that referenced
this pull request
Mar 31, 2024
niceplugin
added a commit
to niceplugin/Vuejs-Pinia-KO
that referenced
this pull request
Mar 31, 2024
* docs: project sync init * docs: zh docs delete and some docs translate using gpt-4-turbo * docs: overlay * docs: markup * fix: opt in to `import.meta.*` properties (vuejs#2622) * docs: certificate links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very early PR to make this module compatible with changes we expect to release in Nuxt v5.
In Nuxt v3.7.0 we added support for
import.meta.*(see original PR) and we've been gradually updating docs and moving across from the oldprocess.*patterned variables.As I'm sure you're aware, these variables are replaced at build-time and enable tree-shaking in bundled code.
This change affects runtime code (that is, that is processed by the Nuxt bundler, like vite or webpack) rather than code running in Node. So it really doesn't matter what the string is, but it makes more sense in an ESM-world to use
import.metarather thanprocess.(It might be worth updating the module compatibility as well to indicate it needs to have Nuxt v3.7.0+, but I'll leave that with you if you think this is a good approach.)