-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use cjs/mjs extensions for cjs/esm builds #1157
Merged
Merged
+552
−426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks a lot for this! I think we should align with Vue. Regarding the changes, it's IMO okay to release this in 4.1.0 with information about the changes necessary for the user. |
Published and testable under the |
A repo with vite & vue cli examples using the published version: https://github.com/danielroe/vue-esm-test and https://github.com/danielroe/vue-esm-test/tree/vue-cli. |
posva
reviewed
May 13, 2022
Co-authored-by: Eduardo San Martin Morote <posva13@gmail.com>
5d6ca0d
to
6db89f0
Compare
posva
added a commit
that referenced
this pull request
May 16, 2022
Co-authored-by: Eduardo San Martin Morote <posva13@gmail.com>
posva
added a commit
that referenced
this pull request
May 16, 2022
Co-authored-by: Eduardo San Martin Morote <posva13@gmail.com>
posva
added a commit
that referenced
this pull request
May 31, 2022
Co-authored-by: Eduardo San Martin Morote <posva13@gmail.com>
posva
added a commit
that referenced
this pull request
Jun 10, 2022
Co-authored-by: Eduardo San Martin Morote <posva13@gmail.com>
Merged
posva
added a commit
that referenced
this pull request
Jun 29, 2022
Co-authored-by: Eduardo San Martin Morote <posva13@gmail.com>
posva
added a commit
that referenced
this pull request
Jun 30, 2022
Co-authored-by: Eduardo San Martin Morote <posva13@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes using
.cjs
and.mjs
instead of the current.js
extensions. That will allow usage of this library in a native Node module context.Notes
.mjs
/.cjs
files for backwards compatibility.vue
,vue
will also need to provide appropriately named native Node module filenames. (This should not negatively affect existing users who will not be using this module natively anyway.)Background issue
At the moment, importing
vue-router
within an ESM context produces the following error: