chore: add translation guide into contributing.md #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-router canceled.
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1778 +/- ##
==========================================
- Coverage 90.86% 90.37% -0.49%
==========================================
Files 24 24
Lines 1116 1195 +79
Branches 347 378 +31
==========================================
+ Hits 1014 1080 +66
- Misses 63 70 +7
- Partials 39 45 +6 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
posva
reviewed
Apr 7, 2023
.github/contributing.md
Outdated
|
|
||
| Currently, all the docs can be found in `packages/docs`. It has a English version by default, and translation(s) in corresponding `<lang>` sub-folder(s): | ||
|
|
||
| - `zh`: Chinese translation. |
There was a problem hiding this comment.
I think we should add a link to the translation folder here as other translations might be hosted in a different repository. This will make more sense after adding an external translation
posva
reviewed
Apr 7, 2023
posva
reviewed
Apr 7, 2023
Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
posva
approved these changes
Apr 7, 2023
Jinjiang
commented
Apr 8, 2023
|
@posva I missed the link to the zh folder. Here it is. |
posva
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1770 (reply in thread)
Thanks.