Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the lint check failure of #921 #944

Closed

Conversation

PeterAlfredLee
Copy link
Contributor

This PR is a fix of #921 .

The declear of changeURL seems doesn't work and the lint check still reports.

I think we can make the routerHistory to be a any object like this :

(routerHistory as any).changeURL = function (url: string) {

WDYT?

@posva posva changed the base branch from master to fix/hash-manual May 14, 2021 10:36
@posva posva changed the base branch from fix/hash-manual to master May 14, 2021 10:36
@posva
Copy link
Member

posva commented May 14, 2021

Thanks but no, I prefer using the ts-ignore or ts-error. Could you comment on the PR instead of making a PR to master, please?

@posva posva closed this May 14, 2021
@posva
Copy link
Member

posva commented May 14, 2021

Thanks for the heads up on the lint error, I fixed that with a different approach in the original PR

@PeterAlfredLee PeterAlfredLee deleted the fix/hash-manual-navigation branch May 17, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants