fix: make imports in wrapperLike relative (again) #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes vuejs#936 (again). It was fixed by vuejs#1184, but then re-broken by vuejs#1180.
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cexbrayat
approved these changes
Apr 6, 2022
wmfgerrit
pushed a commit
to wikimedia/design-codex
that referenced
this pull request
Apr 6, 2022
Upgrade @vue/test-utils 2.0.0-rc.16 -> 2.0.0-rc.19. In this version, the typing of VueWrapper and findComponent are fixed, allowing us to clean up some hacks and type assertions. We do have to enable skipLibCheck because of typing bugs in @vue/test-utils. We can disable that again once vuejs/test-utils#1401 is merged and released. Change-Id: I2b108a793c1f407bc9d54e17678a024b878f06d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #936 (again). It was fixed by #1184, but then re-broken
by #1180.