Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to vue v3.2.32 #1418

Merged
merged 2 commits into from Apr 12, 2022
Merged

chore: bump to vue v3.2.32 #1418

merged 2 commits into from Apr 12, 2022

Conversation

cexbrayat
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Apr 12, 2022

Deploy Preview for vue-test-utils-docs ready!

Name Link
🔨 Latest commit 2f96244
🔍 Latest deploy log https://app.netlify.com/sites/vue-test-utils-docs/deploys/62557905397afb000872ad08
😎 Deploy Preview https://deploy-preview-1418--vue-test-utils-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cexbrayat
Copy link
Member Author

CI is failing because v3.2.32 changed how the root component is used in createApp vuejs/core@d121a9b; The root component is now copied before used.

This broke how we stub components, as we used to add the root component to the list of component to not stub.
As the component is now no longer the same, all tests using shallowMount are failing.

The fix is to register the copy of the component created by Vue in createApp (which is available as app._component)

v3.2.32 changed how the root component is used in `createApp` vuejs/core@d121a9b

The root component is now copied before usage.

This broke how we stub components, as we used to add the root component to the list of component to not stub.
As the component is now no longer the same, all tests using shallowMount are failing.

The fix is to register the copy of the component created by Vue in `createApp` (which is available as `app._component`)
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, shallow mount problems.

@lmiller1990 lmiller1990 merged commit 4ae97e3 into vuejs:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants