New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add proper dependencies #1950
Conversation
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Does this make sense? What if people have a different version of Vue 3 to the one we specified? I am not sure if Test Utils should have a hard dependency on a specific version of Vue 3. Vue Router, for example, does not: https://github.com/vuejs/vue-router/blob/dev/package.json |
I'm not sure about what should be the best practice TBH. @Jinjiang pointed that out on Discord, but maybe this should stay as dev deps and all 3 deps should be specified in peer deps? Or maybe we specify a range for the deps? |
|
I would agree with @freakzlike if we just don't want to lock the version for the users, then peer dependencies would work. |
We were only declaring `devDependencies`, so this refactors the `package.json` to use `dependencies` and `peerDependencies` when it makes sense. `@vue/runtime-core` was also used in some imports, where we could use `vue` directly, so this commit changes this as well.
8f6d349
to
cfdbe83
Compare
I updated the PR with:
Please take another look @lmiller1990 @freakzlike @Jinjiang when you have some time and let me know what you think. (I wonder if we should have |
We were only declaring
devDependencies
, so this refactors thepackage.json
to usedependencies
when it makes sense.@vue/runtime-core
was also used in some imports, where we could usevue
directly, so this commit changes this as well.