Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use attachTo in failing tests with jsdom v21.1 #1952

Merged
merged 1 commit into from Jan 31, 2023
Merged

fix: use attachTo in failing tests with jsdom v21.1 #1952

merged 1 commit into from Jan 31, 2023

Commits on Jan 28, 2023

  1. fix: use attachTo in failing tests with jsdom v21.1 

    `attachTo` can be removed when jsdom/jsdom#3502 is fixed
 With jsdom v21.1, `getComputedStyle` is cached and not updated for elements not in the DOM
 so some our tests fail (because the elements are checked a first time)
    @cexbrayat
    cexbrayat committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    b1fb6a6 View commit details
    Browse the repository at this point in the history