chore: mark @vue/compiler-dom as optional #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should solve the pnpm error: ``` ├─┬ @vue/test-utils 2.2.8 │ └── ✕ missing peer @vue/compiler-dom@^3.0.1 ```
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
freakzlike
approved these changes
Jan 31, 2023
lmiller1990
approved these changes
Feb 1, 2023
cexbrayat
added a commit
to cexbrayat/vue-test-utils-next
that referenced
this pull request
May 11, 2023
We used `optionalDependencies` in vuejs#1958 but I think the proper way is to use `peerDependenciesMeta`. This fixes the current issue where pnpm installs compiler-dom and server-renderer in v3.2.47, despite v3.3.1 being available.
cexbrayat
added a commit
that referenced
this pull request
May 11, 2023
We used `optionalDependencies` in #1958 but I think the proper way is to use `peerDependenciesMeta`. This fixes the current issue where pnpm installs compiler-dom and server-renderer in v3.2.47, despite v3.3.1 being available.
stefpb
added a commit
to stefpb/test-utils
that referenced
this pull request
Aug 31, 2023
Otherwise you get with yarn berry an error @vue/test-utils tried to access @vue/compiler-dom (a peer dependency) but it isn't provided by your application; this makes the require call ambiguous and unsound. May cause vuejs#1958 again. May fixes vuejs#2107.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve the pnpm error:
This was brought to our attention by @Shinigami92 on DIscord