fix: TS workaround for Vue v3.2.47 #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change of types in core (vuejs/core#2818) introduced a TS compilation error when bumping to Vue v3.2.47. I couldn't figure out a proper way to fix, but using `EmitOptions` instead of `E` (which extends `EmitOptions`...) fixes the issue. It may be good enough to allow to update to the latest Vue releases, and I think it should have minimal impact on our users (or none at all).
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lmiller1990
approved these changes
Feb 2, 2023
|
Doing this as a patch, hope it won't be a breaking change for some versions 🤔 |
|
It's out 2.2.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change of types in core (vuejs/core#2818) introduced a TS compilation error when bumping to Vue v3.2.47.
I couldn't figure out a proper way to fix, but using
EmitOptionsinstead ofE(which extendsEmitOptions...) fixes the issue.It may be good enough to allow to update to the latest Vue releases, and I think it should have minimal impact on our users (or none at all).