fix: return wrapper error from DOMWrapper ctor if element is nullish #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lmiller1990
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1984
Rationale: Rather than overriding
existson DomWrapper, I elected to instead return a wrapper error from DomWrapper's ctor if the provided element is nullish.This allows the ctor of DomWrapper to be changed to allow
null | undefinedwithout having to propagatenull | undefineddownwards intoBaseWrapper.constructor,BaseWrapper.wrapperElement,BaseWrapper.element, andWrapperLike.element, a change that would be significantly breaking and cause consumers of test-utils to have to add non-null assertions all over the place.This also simplifies some other uses cases, like for example the one I changed in plugins.md.